Bug 205742 - games/tbe: Fix build, switch to USES=execinfo, other fixes
Summary: games/tbe: Fix build, switch to USES=execinfo, other fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Johan van Selst
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-12-30 22:43 UTC by Pawel Pekala
Modified: 2015-12-31 22:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (johans)


Attachments
Fix build and other (3.10 KB, patch)
2015-12-30 22:43 UTC, Pawel Pekala
no flags Details | Diff
poudriere log (309.94 KB, text/plain)
2015-12-31 13:57 UTC, Rodrigo N. Hernandez
no flags Details
portlint log (2.09 KB, text/plain)
2015-12-31 13:58 UTC, Rodrigo N. Hernandez
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pekala freebsd_committer freebsd_triage 2015-12-30 22:43:56 UTC
Created attachment 164880 [details]
Fix build and other

- Fix build, needs cmake, qmake and USES=compiler:c++11-lib
- Switch to USES=execinfo
- USE_QT4=linguisttools_build for less build dependencies
- Remove INSTALLS_ICONS, it's GTk+ apps only
- Remove DESKTOP_ENTRIES, port installs it's own now
- Fix project CMakeLists.txt to respect PREFIX and install
  files to correct paths
Comment 1 Rodrigo N. Hernandez freebsd_triage 2015-12-31 13:57:00 UTC
Created attachment 164899 [details]
poudriere log

Passes poudriere but warning:
==================================================================
  Unfortunately TBE has a known bug when used with QT 4.7 or 4.8
         This makes it impossible to complete level 17
==================================================================
Comment 2 Rodrigo N. Hernandez freebsd_triage 2015-12-31 13:58:10 UTC
Created attachment 164900 [details]
portlint log

Some warnings and fatal messages
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-12-31 22:05:38 UTC
A commit references this bug:

Author: johans
Date: Thu Dec 31 22:05:14 UTC 2015
New revision: 404965
URL: https://svnweb.freebsd.org/changeset/ports/404965

Log:
  - Fix build, needs cmake, qmake and USES=compiler:c++11-lib
  - Switch to USES=execinfo
  - USE_QT4=linguisttools_build for less build dependencies
  - Remove INSTALLS_ICONS, it's GTk+ apps only
  - Remove DESKTOP_ENTRIES, port installs it's own now
  - Fix project CMakeLists.txt to respect PREFIX and install
    files to correct paths

  PR:		205742
  Submitted by:	pawel

Changes:
  head/games/tbe/Makefile
  head/games/tbe/files/
  head/games/tbe/files/patch-src_model_World.h
Comment 4 Johan van Selst freebsd_committer freebsd_triage 2015-12-31 22:06:00 UTC
Great patch. Committed, thanks.