Bug 205820 - [Patch] lang/go add GOARM=7 when system has multiple CPUs
Summary: [Patch] lang/go add GOARM=7 when system has multiple CPUs
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Julien Laffaye
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-01-03 06:35 UTC by Fukang Chen
Modified: 2018-11-09 09:08 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (jlaffaye)

Attachments
add GOARM=7 (1.03 KB, text/plain)
2016-01-03 06:35 UTC, Fukang Chen 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fukang Chen freebsd_committer freebsd_triage 2016-01-03 06:35:52 UTC 
Created attachment 164981 [details]
add GOARM=7

Got this message on my BananaPi
http://p.defau.lt/?seTYSCcDbdpqRpn3JbUXww

##### Building packages and commands for freebsd/arm.
runtime: this system has multiple CPUs and must use
atomic synchronization instructions. Recompile using GOARM=7.
*** Error code 1

Here's the poudriere log with GOARM=7
http://p.defau.lt/?VcrpI6u6ZQ9WFLpFH9_2tw
Comment 1 Julien Laffaye freebsd_committer freebsd_triage 2016-01-03 09:59:19 UTC 
Well, it is supposed to do the right thing(tm):
https://github.com/golang/go/wiki/GoArm

Are you cross-compiling ?
Comment 2 Fukang Chen freebsd_committer freebsd_triage 2016-01-03 15:16:22 UTC 
I'm running poudriere on a Banana Pi, it has a SATA port, so I just compile the ports there. 

Not sure if it has to be GOARM=7,  it runs fine on my FreeBSD armv6 boards.
it just checks for the number of CPUs while compiling
https://github.com/golang/go/blob/master/src/runtime/os_freebsd_arm.go#L11

I guess it would be the same message on Raspberry Pi 2. 

Thanks,
Comment 3 florian.heigl 2016-02-15 13:43:00 UTC 
Same issue on stock raspberrypi2 when i tried to build sysutils/freebsd-docker.

This is not an endorsement of docker ;)
Comment 4 florian.heigl 2016-02-20 19:18:56 UTC 
Tested patch with lang/go and lang/go14

Works well though I had to manually apply it for whatever reason. Probably just did something wrong.