Bug 205821 - [patch] bsdinstall(8): kill dhclient before trying to get an IP
Summary: [patch] bsdinstall(8): kill dhclient before trying to get an IP
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 10.2-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Allan Jude
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-01-03 08:33 UTC by will
Modified: 2020-07-11 17:20 UTC (History)
1 user (show)

See Also:
allanjude: mfc-stable12?
allanjude: mfc-stable11?


Attachments
kill dhclient before starting a new instance (563 bytes, patch)
2016-01-03 08:33 UTC, will
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description will 2016-01-03 08:33:40 UTC
Created attachment 164983 [details]
kill dhclient before starting a new instance

Currently, if you're re-routed to the beginning of the install process or to the beginning of the netconfig process, subsequent attempts to configure via dhclient will fail as dhclient is already running.

Since there are many ways to get into this state, we should kill any dhclients prior to configuring the primary interface with dhcp.

Tested on FreeBSD 10.2-STABLE amd64.
Comment 1 will 2018-03-03 08:28:03 UTC
https://reviews.freebsd.org/D14572
Comment 2 commit-hook freebsd_committer 2020-07-11 15:33:06 UTC
A commit references this bug:

Author: allanjude
Date: Sat Jul 11 15:32:53 UTC 2020
New revision: 363097
URL: https://svnweb.freebsd.org/changeset/base/363097

Log:
  bsdinstall: kill dhclient before starting a new instance

  PR:		205821
  Submitted by:	William Orr <will@worrbase.com>
  MFC after:	2 weeks
  Sponsored by:	Klara Inc.
  Event:		July 2020 Bugathon
  Differential Revision:	https://reviews.freebsd.org/D14572

Changes:
  head/usr.sbin/bsdinstall/scripts/netconfig_ipv4
Comment 3 commit-hook freebsd_committer 2020-07-11 17:20:45 UTC
A commit references this bug:

Author: allanjude
Date: Sat Jul 11 17:20:17 UTC 2020
New revision: 363103
URL: https://svnweb.freebsd.org/changeset/base/363103

Log:
  bsdinstall: only kill the dhclient for the interface we are restarting

  PR:		205821
  Reported by:	mjg
  MFC after:	2 weeks
  Sponsored by:	Klara Inc.
  Event:		July 2020 Bugathon

Changes:
  head/usr.sbin/bsdinstall/scripts/netconfig_ipv4