Bug 205874 - [patch] Don't (try to) build rtwnfw if the user objects to binary blobs
Summary: [patch] Don't (try to) build rtwnfw if the user objects to binary blobs
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-01-04 13:32 UTC by Fabian Keil
Modified: 2016-01-04 19:05 UTC (History)
1 user (show)

See Also:

Attachments
[patch] Don't (try to) build rtwnfw if the user objects to binary blobs (855 bytes, patch)
2016-01-04 13:32 UTC, Fabian Keil 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Keil 2016-01-04 13:32:23 UTC 
Created attachment 165052 [details]
[patch] Don't (try to) build rtwnfw if the user objects to binary blobs

The rtwnfw module contains source-less and non-free microcode
but is built and installed even if WITHOUT_SOURCELESS_UCODE is set.

The attached patch fixes this. It should apply cleanly once
the same issue is fixed for otusfw (#204748).

Obtained from: ElectroBSD
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-01-04 19:04:58 UTC 
A commit references this bug:

Author: brueffer
Date: Mon Jan  4 19:04:33 UTC 2016
New revision: 293171
URL: https://svnweb.freebsd.org/changeset/base/293171

Log:
  Don't build rtwnfw if building without binary blobs.

  rtwnfw got added in r293009 and depends on source-less and
  non-free microcode in sys/contrib/dev/rtwn.

  PR:		205874
  Submitted by:	Fabian Keil
  Obtained from:	ElectroBSD

Changes:
  head/sys/modules/Makefile
Comment 2 Christian Brueffer freebsd_committer freebsd_triage 2016-01-04 19:05:50 UTC 
Committed, thanks!