Bug 205876 - Remove portmgr@ as blocking review for all Mk/* files
Summary: Remove portmgr@ as blocking review for all Mk/* files
Status: Closed FIXED
Alias: None
Product: Services
Classification: Unclassified
Component: Code Review (show other bugs)
Version: unspecified
Hardware: Any Any
: --- Affects Some People
Assignee: Phabric Admin
URL: https://reviews.freebsd.org/D3585
Keywords: dogfood, feature, needs-qa
Depends on:
Reported: 2016-01-04 13:47 UTC by Bernard Spil
Modified: 2019-09-24 03:41 UTC (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer 2016-01-04 13:47:27 UTC
When creating reviews that touch files in Mk/ , portmgr is added as a Project reviewer and the review will be in Portmgr blocking review state.

This is incorrect as not all files in Mk/ are managed by portmgr@ (e.g. bsd.openssl.mk is maintained by dinoex@)

Please check the maintainer in the file for blocking reviews.

Example review https://reviews.freebsd.org/D3585

Relevant Herald rule https://reviews.freebsd.org/H12
When all of these conditions are met:
 - Repository is any of rP FreeBSD ports repository
 - Affected files matches regexp @/(Mk|Keywords|Templates)/.*$@
Take these actions every time this rule matches:
 - Add blocking reviewers: portmgr.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-04 13:50:25 UTC
If any MAINTAINER lines need changing in order to satisfy this issue consistently/programatically, we'll create a blocking issue for it.
Comment 2 Mathieu Arnold freebsd_committer 2016-05-10 16:13:27 UTC
I'm going to close this.

The reason are:
- fine tuning, and maintaining, the herald rule will be a major PITA.
- if you know the things you're reviewing don't concern portmgr, then don't wait for them because you can always commit the change if it has bad review.
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2016-05-16 08:47:28 UTC
FWIW this is now actually actionable by editing the paths here: https://reviews.freebsd.org/owners/package/5/ (it supports files & directories: include and exclude lines).