Bug 205907 - devel/py-ipaddr: Update to 2.1.11, fix build failure with Python 3, cleanup
Summary: devel/py-ipaddr: Update to 2.1.11, fix build failure with Python 3, cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/google/ipaddr-py/p...
Keywords: easy, needs-qa, patch
Depends on:
Blocks: 205789
  Show dependency tree / graph
 
Reported: 2016-01-05 00:51 UTC by VK
Modified: 2016-01-10 19:02 UTC (History)
3 users (show)

See Also:
mopsfelder: maintainer-feedback+

Attachments
Update to 2.1.11, fix build issues with python 3, cleanup (5.90 KB, patch)
2016-01-05 00:51 UTC, VK 		no flags Details | Diff
Update to 2.1.11, fix build issues with python 3, cleanup (5.89 KB, patch)
2016-01-05 09:13 UTC, VK 		koobs: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description VK 2016-01-05 00:51:29 UTC 
Created attachment 165085 [details]
Update to 2.1.11, fix build issues with python 3, cleanup

devel/ipaddr fails to build against python 3. This patch fixes that, including some clean-up and update to latest version.

The patch:

* Updates to 2.1.11 (from 2.1.10)
* Adds patches that make the port python3 compatible
* Adds license
* Sets MASTER_SITE to CHEESESHOP as the google code page is no more, it moved to GitHub with no clear versioning (no tags, no clear commit that defines version)
* minor clean-up to quiet portlint

Portlint OK. Poudriere OK (10.2 and 9.3; amd64; Python 3.4 and Python 3.5). Also passes own tests with python2.7, python3.4 and python3.5.

This apparently blocks bug #205789.
Comment 1 VK 2016-01-05 00:52:23 UTC 
CC python@
Comment 2 VK 2016-01-05 09:13:32 UTC 
Created attachment 165096 [details]
Update to 2.1.11, fix build issues with python 3, cleanup

Saner long(). Fixed www in pkg-descr.
Comment 3 Dmitry Sivachenko freebsd_committer freebsd_triage 2016-01-05 09:29:13 UTC 
Can you please submit your patch upstream so it is included into next release?
Comment 4 VK 2016-01-07 17:16:22 UTC 
(In reply to Dmitry Sivachenko from comment #3)

Done.  https://github.com/google/ipaddr-py/pull/118
Comment 5 Murilo Opsfelder Araújo 2016-01-09 14:30:14 UTC 
Hello, Vladmir, Dmitry.

(Happy new year!)

Do you still need the maintainer approval or was it handled in upstream?

I'm away from FreeBSD nowadays and would be great if someone could kindly verify.  Dmitry?
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-09 14:45:53 UTC 
Comment on attachment 165096 [details]
Update to 2.1.11, fix build issues with python 3, cleanup

Definitely set maintainer-approval to + if you approve, thank you!
Comment 7 Murilo Opsfelder Araújo 2016-01-09 15:35:45 UTC 
(In reply to Kubilay Kocak from comment #6)

Done.  Thanks, Kubilay.
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-09 15:36:20 UTC 
Comment on attachment 165096 [details]
Update to 2.1.11, fix build issues with python 3, cleanup

This one here :) (maintainer-approval on attachment)
Comment 9 Murilo Opsfelder Araújo 2016-01-09 15:41:03 UTC 
(In reply to Kubilay Kocak from comment #8)

Is it all set or do I need to flag somewhere else?
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-09 15:44:21 UTC 
(In reply to Murilo Opsfelder Araújo from comment #9)

I've set it for you this time, it's not in the most obvious place :)

Attachment -> Details -> Flag: maintainer-approval [+]

This is distinct from the maintainer-feedback flag, which is at the 'issue' level, which you use to indicate you have 'responded' to a request for feedback. It's unrelated to 'approval' of changes

You may also mouse over the name of any flag, to see a description of it, and example usages

Hope that helps Murilo!
Comment 11 Murilo Opsfelder Araújo 2016-01-09 16:46:09 UTC 
(In reply to Kubilay Kocak from comment #10)

Thanks for the explanation, Kubilay.
Comment 12 commit-hook freebsd_committer freebsd_triage 2016-01-10 19:01:35 UTC 
A commit references this bug:

Author: demon
Date: Sun Jan 10 19:01:17 UTC 2016
New revision: 405739
URL: https://svnweb.freebsd.org/changeset/ports/405739

Log:
  Update to version 2.1.11.
  Add fixes for python3.
  Change master-site to CHEESESHOP.

  PR:		205907
  Submitted by:	Vladimir Krstulja <vlad-fbsd@acheronmedia.com>
  Approved by:	maintainer

Changes:
  head/devel/py-ipaddr/Makefile
  head/devel/py-ipaddr/distinfo
  head/devel/py-ipaddr/files/
  head/devel/py-ipaddr/files/patch-ipaddr.py
  head/devel/py-ipaddr/files/patch-ipaddr_test.py
  head/devel/py-ipaddr/pkg-descr
Comment 13 Dmitry Sivachenko freebsd_committer freebsd_triage 2016-01-10 19:01:48 UTC 
Port updated, thanks!