Created attachment 165111 [details] one-line patch to fix options anomaly of maildrop The way maildrop gets its options has resulted in an unwanted side effect. Currently, "make showconfig" produces: ===> The following configuration options are available for maildrop-2.8.3_2: AUTHLIB=off: Courier Auth Library support DOCS=off: Build and/or install documentation DOVECOTAUTH=off: Dovecot Authentication support FAM=off: File Alteration Monitor support GDBM=off: GNU dbm library support IDN=off: International Domain Names support MAILWRAPPER=off: Let configure guess which sendmail binary to use ====> Courier Auth Library support: you have to choose at least one of them AUTH_LDAP=off: LDAP support AUTH_MYSQL=off: MySQL support AUTH_PGSQL=off: PostgreSQL support AUTH_USERDB=off: Userdb support AUTH_VCHKPW=off: popmail/vchkpw support DOCS=off: Build and/or install documentation ===> Use 'make config' to modify these settings Noe that "DOCS" appears both in the single options list and the group list With the attached patch, "make showconfig" produces: ===> The following configuration options are available for maildrop-2.8.3_2: AUTHLIB=off: Courier Auth Library support DOCS=on: Build and/or install documentation DOVECOTAUTH=off: Dovecot Authentication support FAM=off: File Alteration Monitor support GDBM=off: GNU dbm library support IDN=off: International Domain Names support MAILWRAPPER=off: Let configure guess which sendmail binary to use ====> Courier Auth Library support: you have to choose at least one of them AUTH_LDAP=off: LDAP support AUTH_MYSQL=off: MySQL support AUTH_PGSQL=off: PostgreSQL support AUTH_USERDB=off: Userdb support AUTH_VCHKPW=off: popmail/vchkpw support ===> Use 'make config' to modify these settings (DOCS no longer appears in the Couriere Auth Library group) I assume that's the desired situation. There should only be one DOCS option for the port IMHO.
Thanks for the patch, I never spotted it, and yes, DOCS should appears just once. I'll commit this shortly.
I'll also ask to merge this to quarterly.
@Guido, set to + once committed, or - if it gets rejected or its unnecessary Thank you! :D
A commit references this bug: Author: madpilot Date: Wed Jan 6 11:34:36 UTC 2016 New revision: 405342 URL: https://svnweb.freebsd.org/changeset/ports/405342 Log: Stop DOCS option appearing twice in this port. PR: 205924 Submitted by: marino@ MFH: 2016Q1 Changes: head/mail/maildrop/Makefile
A commit references this bug: Author: madpilot Date: Wed Jan 6 11:52:24 UTC 2016 New revision: 405344 URL: https://svnweb.freebsd.org/changeset/ports/405344 Log: MFH: r405342 Stop DOCS option appearing twice in this port. PR: 205924 Submitted by: marino@ Approved by: portmgr (erwin) Changes: _U branches/2016Q1/ branches/2016Q1/mail/maildrop/Makefile
Commited and merged to quarterly! Thanks.