Bug 205924 - [patch] mail/maildrop: Fix anomaly in OPTIONS (DOCS appears twice)
Summary: [patch] mail/maildrop: Fix anomaly in OPTIONS (DOCS appears twice)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2016-01-05 16:42 UTC by John Marino
Modified: 2016-01-06 11:54 UTC (History)
0 users

See Also:
madpilot: maintainer-feedback+
madpilot: merge-quarterly+


Attachments
one-line patch to fix options anomaly of maildrop (486 bytes, patch)
2016-01-05 16:42 UTC, John Marino
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer 2016-01-05 16:42:06 UTC
Created attachment 165111 [details]
one-line patch to fix options anomaly of maildrop

The way maildrop gets its options has resulted in an unwanted side effect.  

Currently, "make showconfig" produces: 

===> The following configuration options are available for maildrop-2.8.3_2:
     AUTHLIB=off: Courier Auth Library support
     DOCS=off: Build and/or install documentation
     DOVECOTAUTH=off: Dovecot Authentication support
     FAM=off: File Alteration Monitor support
     GDBM=off: GNU dbm library support
     IDN=off: International Domain Names support
     MAILWRAPPER=off: Let configure guess which sendmail binary to use
====> Courier Auth Library support: you have to choose at least one of them
     AUTH_LDAP=off: LDAP support
     AUTH_MYSQL=off: MySQL support
     AUTH_PGSQL=off: PostgreSQL support
     AUTH_USERDB=off: Userdb support
     AUTH_VCHKPW=off: popmail/vchkpw support
     DOCS=off: Build and/or install documentation
===> Use 'make config' to modify these settings

Noe that "DOCS" appears both in the single options list and the group list

With the attached patch, "make showconfig" produces:
===> The following configuration options are available for maildrop-2.8.3_2:
     AUTHLIB=off: Courier Auth Library support
     DOCS=on: Build and/or install documentation
     DOVECOTAUTH=off: Dovecot Authentication support
     FAM=off: File Alteration Monitor support
     GDBM=off: GNU dbm library support
     IDN=off: International Domain Names support
     MAILWRAPPER=off: Let configure guess which sendmail binary to use
====> Courier Auth Library support: you have to choose at least one of them
     AUTH_LDAP=off: LDAP support
     AUTH_MYSQL=off: MySQL support
     AUTH_PGSQL=off: PostgreSQL support
     AUTH_USERDB=off: Userdb support
     AUTH_VCHKPW=off: popmail/vchkpw support
===> Use 'make config' to modify these settings

(DOCS no longer appears in the Couriere Auth Library group)
I assume that's the desired situation.  There should only be one DOCS option for the port IMHO.
Comment 1 Guido Falsi freebsd_committer 2016-01-05 17:01:56 UTC
Thanks for the patch, I never spotted it, and yes, DOCS should appears just once.

I'll commit this shortly.
Comment 2 Guido Falsi freebsd_committer 2016-01-05 17:21:22 UTC
I'll also ask to merge this to quarterly.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-05 17:30:40 UTC
@Guido, set to + once committed, or - if it gets rejected or its unnecessary

Thank you! :D
Comment 4 commit-hook freebsd_committer 2016-01-06 11:34:42 UTC
A commit references this bug:

Author: madpilot
Date: Wed Jan  6 11:34:36 UTC 2016
New revision: 405342
URL: https://svnweb.freebsd.org/changeset/ports/405342

Log:
  Stop DOCS option appearing twice in this port.

  PR:		205924
  Submitted by:	marino@
  MFH:		2016Q1

Changes:
  head/mail/maildrop/Makefile
Comment 5 commit-hook freebsd_committer 2016-01-06 11:52:46 UTC
A commit references this bug:

Author: madpilot
Date: Wed Jan  6 11:52:24 UTC 2016
New revision: 405344
URL: https://svnweb.freebsd.org/changeset/ports/405344

Log:
  MFH: r405342

  Stop DOCS option appearing twice in this port.

  PR:		205924
  Submitted by:	marino@

  Approved by:	portmgr (erwin)

Changes:
_U  branches/2016Q1/
  branches/2016Q1/mail/maildrop/Makefile
Comment 6 Guido Falsi freebsd_committer 2016-01-06 11:54:50 UTC
Commited and merged to quarterly! Thanks.