Created attachment 165201 [details] Patch with port updates. Proposed patch updates the port to the latest version of 0.9.9. Upstream radare2 uses git submodules for its dependency on capstone pulling from capstone repo on every build invocation. But for the purpose of this port radare2 is configured to build with capstone available in the system (devel/capstone port). This also ensures similar configuration/build for a given radare2 and capstone ports combination.
Hi, Build fails for 9.X http://pkgdev2.miwibox.org/data/93amd64-b-miwi/2016-01-17_02h08m29s/logs/errors/radare2-0.9.9.log
(In reply to Martin Wilke from comment #1) Confirmed the build failed for me, though with a different error. Let me check it and I'll try to get it fixed. In order to try reproduce your failure, how is this port configured for you?
Created attachment 165734 [details] Patch with port updates. Fixed.
Created attachment 165735 [details] Poudriere build log
Created attachment 165736 [details] Poudriere build log
Updated the patch. Also attached build logs for 10.2 and 9.3.
Testbuilds done on 11, 10.2a+i, 9.3a, all fail at the same place: /wrkdirs/usr/ports/devel/radare2/work/radare2-0.9.9/libr/../global.mk:40: recipe for target 'zip_dirent.o' failed See http://people.freebsd.org/~pi/logs/devel__radare2-10a-1454137431.txt etc. Any ideas for the cause ?
Messed up the quote: zip_dirent.c:113:24: error: use of undeclared identifier 'SIZE_MAX' else if ((nentry > SIZE_MAX/sizeof(*(cd->entry))) || (cd->entry=(str... ^
(In reply to Kurt Jaeger from comment #8) radare2 uses some included ZIP code, and files/patch* has a fix for a CVE. There's the option to use --with-syszip, but it fails to touch all the bases.
I found a fix for the build problem, testbuilds@work.
Created attachment 166304 [details] updated-patch
A commit references this bug: Author: pi Date: Sat Jan 30 15:32:46 UTC 2016 New revision: 407531 URL: https://svnweb.freebsd.org/changeset/ports/407531 Log: devel/radare2: 0.9.8 -> 0.9.9 Changes: http://radare.today/posts/radare-0-9-9/ PR: 205996 Submitted by: oleksii.tsai@gmail.com Approved by: torres.73a@gmail.com (maintainer timeout) Changes: head/devel/radare2/Makefile head/devel/radare2/distinfo head/devel/radare2/files/patch-CVE-2015-2331 head/devel/radare2/pkg-plist
Committed, thanks!
Comment on attachment 166304 [details] updated-patch Maintainer timeout (24 days), implicit approval
(In reply to Kurt Jaeger from comment #8) SIZE_MAX comes from stdint.h. My original patch had that include but I screwed up when I updated the patch and that line got lost.