Created attachment 165269 [details]
Diff to upgrade py-novaclient to 3.2.0
The attached patch upgrade the port to 3.2.0 (didn't try using poudriere, I'm using this on 10.2-p7).
Thank you for the patch, Davide.
It's not as simple as that, though, because it needs some dependencies changes as well.
I'm working on that.
Created attachment 165348 [details]
Path for py-novaclient. Added required ports.
Hi K, thanks for your feedback.
Unfortunately I didn't have poudriere, so wasn't able to full test the previous patch.
Please find attached a new one, including missing (and required ports) where I put you as mantainer (I hope you don't mind :) but if this is an issue, I will be honoured to maintain them).
A quick note: py-monotonic should be installed if python_ver is 2.x or < 3.3 (cfr. https://pypi.python.org/pypi/monotonic/0.5)
Created attachment 165349 [details]
Change email@example.com with my email to mantain new ports. Remove comments from Makefiles.
Ok, I can maintain ports I added :)
Created attachment 165350 [details]
Fixed a typo in oslo.serialization/distinfo.
@Davide, very nice work :)
What we'll need is separate issues for each new port, with this issue "depends on" those issue <ID>'s, where appropriate.
Regarding py-monotonic, there is an existing review open for it:
Also, the COMMENT for each of the new python ports should match its setup.py:description (shortened, and compliant with portlint as necessary)
So, in summary:
* Split out the new changes ports into separate issues (as shell archives)
* Obsolete the existing attachment here, attach the py-novaclient update only
* Have this issue "depend on" the other new port issue issue ids
Hope that helps
I suspected that :)
Ok, I'll be on this in 8h (it's not raining here in London, so time to go out :)).
FWIW, I already have oslo.utils and oslo.i18n ports ready. You can save yourself a little time and submit oslo.serialization though (but pay attention to their deps as well. Also, I think pbr is required to be build depend as well).
- py-monotonic (https://reviews.freebsd.org/D4845) committed
- py-oslo.i18n is here: https://reviews.freebsd.org/D4850
Added review request for py-debtcollector, based on your patch:
Changes I made to your port:
- wrapped pkg-plist
- refined dependencies (based on the project's requirements.txt)
- update WWW to more appropriate resource
Please post your comments there.
Thanks, fine for me.
The devel/py-debtcollector is in, maintainer set to Davide as in the original patch.
Davide, as far as I understand, you'd like to maintain the oslo ports? If you, I'd change the patches to set you maintainer.
Actually I am interested in py-novaclient so if I have to mantain the oslo-* ports, I'll do, no big deal.
Well, it's not like you have to, if you don't feel like wanting to do that, I can pick them up, it's up to you. :)
Meanwhile, py-oslo.serialization review request uploaded:
Includes some changes to the original version (deps list most importantly).
No worries, I am not managing any ports at the moment so it's fine :)
Actually you are:
Then what I propose is that I keep oslo.utils and oslo.i18n (because I created it before your patch) and I set you as a maintainer for oslo.serialization and keystoneclient1 (because for those I based on the ports you submitted through the diff).
Meanwhile, review request for py-keystoneauth1 created:
Looks like it's the last requirement before proceeding with the novaclient update.
Absolutely fine, let's go for it so we can have an updated py-novaclient.
A commit references this bug:
Date: Fri Jan 15 00:52:01 UTC 2016
New revision: 406132
net/py-novaclient: update to 3.2.0 and un-break
Submitted by: Davide D'Amico <firstname.lastname@example.org>
Woo, now it's done!
Davide, thanks for your contribution!
The ports you now maintain are listed here:
I've added you to the list of Additional Contributors:
Few suggestions on the port maintainership:
- Be careful with dependencies, for Python port explore setup.py, setup.cfg, requirements.txt etc
- Do not forget to use portlint and 'make check-orphans'
- Would be awesome if you could setup poudriere (it's not very hard)