Bug 206061 - ports-mgmt/portlint: Doesn't parse ${VARIABLES} in right half of *_DEPENDS (WARN False Positive)
Summary: ports-mgmt/portlint: Doesn't parse ${VARIABLES} in right half of *_DEPENDS (W...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords: dogfood, needs-qa
Depends on:
Blocks:
 
Reported: 2016-01-09 09:45 UTC by Kubilay Kocak
Modified: 2016-04-15 18:32 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kubilay Kocak freebsd_committer freebsd_triage 2016-01-09 09:45:57 UTC 
portlint doesn't parse ${VARIABLES} in *_DEPENDS lines, resulting in a warning:

WARN: Makefile: no port directory /usr/ports/devel/py-setuptools${PYTHON_SUFFIX} found, even though it is listed in BUILD_DEPENDS.

devel/py-mock/Makefile:

BUILD_DEPENDS=  ${PYTHON_PKGNAMEPREFIX}pbr>=1.3:${PORTSDIR}/devel/py-pbr \
                ${PYTHON_PKGNAMEPREFIX}setuptools${PYTHON_SUFFIX}>0:${PORTSDIR}/devel/py-setuptools${PYTHON_SUFFIX}

make build-depends-list:
/usr/home/koobs/repos/freebsd/ports/devel/py-pbr
/usr/home/koobs/repos/freebsd/ports/devel/py-setuptools27
/usr/home/koobs/repos/freebsd/ports/lang/python27
/usr/home/koobs/repos/freebsd/ports/ports-mgmt/pkg

A number of ports use similar constructs, in both left-hand and right-hand sides of the *_DEPENDS tuple. My regex foo isn't fantastic, but this found quite a few:

find /usr/ports -name Makefile -exec grep -E ':\$\{PORTSDIR\}\/.*\$\{.*\}' {} +
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2016-04-13 16:26:53 UTC 
Fix committed to my CVS repo pending the next release.  It would be good if you could test:

http://www.marcuscom.com/cgi-bin/cvsweb.cgi/portlint/portlint.pl.diff?r1=1.383&r2=1.384&f=h
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2016-04-15 18:32:16 UTC 
Fixed in 2.17.0.