Bug 206093 - www/libevhtp: Fails check-plist with REGEX option selected (pkg-plist file missing in STAGEDIR)
Summary: www/libevhtp: Fails check-plist with REGEX option selected (pkg-plist file mi...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks: 203933
  Show dependency tree / graph
 
Reported: 2016-01-10 10:53 UTC by Kurt Jaeger
Modified: 2016-01-12 19:56 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (Ultima1252)
koobs: merge-quarterly?

Attachments
libevhtp.diff (1.63 KB, patch)
2016-01-10 20:19 UTC, Ultima 		Ultima1252: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2016-01-10 10:53:59 UTC 
error:

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: include/onigposix.h
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/www/libevhtp
# grep onigposix pkg-plist 
%%REGEX%%include/onigposix.h
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-10 11:02:53 UTC 
Reporter is Committer, assign accordingly.

This change is covered under blanket (implicit) approval
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2016-01-10 11:20:51 UTC 
It's more complicated:

libevhtp brings its own copy of oniguruma5, and instead should lib_depend on it,
otherwise it would conflict with oniguruma5.
Comment 3 Ultima 2016-01-10 15:06:45 UTC 
 Working on patch, the 0.1.11 update changed the home of the header files to include/evhtp I removed this change, Ill do a proper fix like I should have in the first place.

 This will break building seafile tho. Most of the features in seafile are broken with this version of libevhtp already tho.

 Using oniguruma5 over libevhtp's oniguruma breaks libevhtp. So I cant add it as a depend.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2016-01-10 15:28:19 UTC 
> Using oniguruma5 over libevhtp's oniguruma breaks libevhtp.

Can you open an issue upstream about that ?
Comment 5 Ultima 2016-01-10 20:19:06 UTC 
Created attachment 165373 [details]
libevhtp.diff

 This patch will fix conflicts with oniguruma* as well as fix some breaks when oniguruma* is installed.

 * Removed striped hierarchy for headers
 * Removed system oniguruma detection
 * Fixed headers




 Will open issue upstream once I have more details on the breaks
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-01-12 19:56:10 UTC 
A commit references this bug:

Author: pi
Date: Tue Jan 12 19:55:48 UTC 2016
New revision: 405906
URL: https://svnweb.freebsd.org/changeset/ports/405906

Log:
  www/libevhtp: fix conflicts with oniguruma*...

  ... as well as fix some breaks when oniguruma* is installed.

  - Removed striped hierarchy for headers
  - Removed system oniguruma detection
  - Fixed headers

  PR:		206093
  Submitted by:	Ultima1252@gmail.com (maintainer)

Changes:
  head/www/libevhtp/Makefile
  head/www/libevhtp/pkg-plist
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2016-01-12 19:56:41 UTC 
Committed, thanks!