@Mokhi, can you produce a patch against the current port using make makepatch method please. Also confirm it passes QA (portlint, poudriere) after the change. Thank you!
Created attachment 165364 [details] patch fixes (patch generated against port-tree HEAD)
Hi Mokhi, looks good for me, but from where is the patch for whine.pl? 17 use Bugzilla::User; 18 -use Bugzilla::Mailer; 19 +use Bugzilla::Mailer qw(MessageToMTA generate_email); 20 use Bugzilla::Util; I just cloned the upstream git and found only the addition 'use Bugzilla::MIME;'
these lines is for making perl to use exported symbol "generate_email" in current file. Bugzilla guys used this too :) AFAIK this is the change they planned to use in their next release (unless they change their decision :D) Inside upstream git there are many experimental (unless you cloned their stable), don't rely on that :D I should add, problem will be fixed in next release and they've suggested us to use these changes to fix it on current releases (5.0.2) Thanks, Mokhi
OK, do you have already a commit bit? If yes, please go on and commit your patch, if not Koobs or I can do it. I suspect this patch should be also MFC 2016Q1
(In reply to Olli Hauer from comment #5) I don't have commit bit, commit it for me please :D Thanks, Mokhi.
A commit references this bug: Author: ohauer Date: Sun Jan 10 17:04:48 UTC 2016 New revision: 405729 URL: https://svnweb.freebsd.org/changeset/ports/405729 Log: - Backport upstream bug #1235395 PR: 206103 Submitted by: Mahdi Mokhtari <mokhi64 _at_ gmail.com> Obtained from: https://bugzilla.mozilla.org/show_bug.cgi?id=1235395 MFH: 2016Q1 Changes: head/devel/bugzilla50/Makefile head/devel/bugzilla50/files/patch-PR206103
(In reply to commit-hook from comment #7) Thanks Olli!
(In reply to Kubilay Kocak from comment #8) thanks Olli, thanks Kubilay :D
You are welcome!
Re-open: Still pending MFH. Set merge-quarterly flag value to + after commit Ideally it contains this PR: <ID> reference too :)
A commit references this bug: Author: ohauer Date: Mon Jan 11 18:53:22 UTC 2016 New revision: 405797 URL: https://svnweb.freebsd.org/changeset/ports/405797 Log: MFH: r405729 - Backport upstream bug #1235395 PR: 206103 Submitted by: Mahdi Mokhtari <mokhi64 _at_ gmail.com> Obtained from: https://bugzilla.mozilla.org/show_bug.cgi?id=1235395 Approved by: portmgr (feld@) Changes: _U branches/2016Q1/ branches/2016Q1/devel/bugzilla50/Makefile branches/2016Q1/devel/bugzilla50/files/patch-PR206103