Bug 206224 - bv_cnt is sometimes examined without holding the bufobj lock
Summary: bv_cnt is sometimes examined without holding the bufobj lock
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
Keywords: patch
Depends on:
Reported: 2016-01-14 04:13 UTC by Ravi Pokala
Modified: 2019-01-21 18:05 UTC (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Ravi Pokala 2016-01-14 04:13:44 UTC
While looking at other stuff, a colleague found that bv_cnt was sometimes looked at without the corresponding bufobj being locked.
Comment 1 Ravi Pokala 2016-01-14 04:35:26 UTC
Proposed patch on Phabricator: https://reviews.freebsd.org/D4931
Comment 2 commit-hook freebsd_committer 2016-01-17 01:05:21 UTC
A commit references this bug:

Author: rpokala
Date: Sun Jan 17 01:04:20 UTC 2016
New revision: 294200
URL: https://svnweb.freebsd.org/changeset/base/294200

  [PR 206224] bv_cnt is sometimes examined without holding the bufobj lock

  Add locking around access to bv_cnt which is currently being done unlocked

  PR:		206224
  Reviewed by:	imp
  Approved by:	jhb
  MFC after:	1 week
  Sponsored by:	Panasas, Inc.
  Differential Revision:	https://reviews.freebsd.org/D4931

Comment 3 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-01-21 18:05:57 UTC
There is a commit referencing this PR, but it's still not closed and has been inactive for some time. Closing the PR as fixed but feel free to re-open it if the issue hasn't been completely resolved.