Bug 206378 - devel/qt5 remove deprecated PLIST_DIRSTRY
Summary: devel/qt5 remove deprecated PLIST_DIRSTRY
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-01-18 20:05 UTC by Pawel Pekala
Modified: 2016-01-20 17:31 UTC (History)
1 user (show)

See Also:
rakuco: maintainer-feedback+


Attachments
remove PLIST_DIRSTRY (599 bytes, patch)
2016-01-18 20:05 UTC, Pawel Pekala
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pekala freebsd_committer freebsd_triage 2016-01-18 20:05:18 UTC
Created attachment 165776 [details]
remove PLIST_DIRSTRY
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-19 04:06:58 UTC
Reporter is committer, changes are blanket, implicit approval. Assign accordingly, keep maintainer CC'd
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-01-19 16:50:43 UTC
Looks sane to me, please go ahead. You also need to bump PORTREVISION in the relevant ports since it changes the package manifest.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-01-20 16:19:06 UTC
A commit references this bug:

Author: pawel
Date: Wed Jan 20 16:18:03 UTC 2016
New revision: 406778
URL: https://svnweb.freebsd.org/changeset/ports/406778

Log:
  Remove deprecated PLIST_DIRSTRY

  PR:		206378
  Submitted by:	myself
  Approved by:	rakuco

Changes:
  head/devel/qt5/Makefile.sqldrivers
Comment 4 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-01-20 16:45:54 UTC
The change is incomplete, you have to bump PORTREVISION in the affected ports.
Comment 5 Pawel Pekala freebsd_committer freebsd_triage 2016-01-20 17:14:50 UTC
Disagree, plist of slave ports don't change and pkg is smart enough now
to remove directories you install files to on deinstall so I don't see any
reason to PORTREVISION bump here.
In last 5 weeks I've converted 50+ ports with similar
changes and did not get any comments about bumps.
Comment 6 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-01-20 17:31:56 UTC
It looks like I've interpreted the "PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way" too strictly, so closing again.

Still, you could have said you disagreed with comment #2 before.