Bug 206431 - net/opensips: Update to 2.1.2
Summary: net/opensips: Update to 2.1.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-20 12:52 UTC by Euan Thoms
Modified: 2016-01-20 19:48 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback+


Attachments
Diff patch between current port version and upgrade to v2.1.2 (1.56 KB, patch)
2016-01-20 12:52 UTC, Euan Thoms
euan: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Euan Thoms 2016-01-20 12:52:19 UTC
Created attachment 165863 [details]
Diff patch between current port version and upgrade to v2.1.2

Simple update to latest version. Only had to change version numbers and checksums in Makefile and distinfo, not even any pkg-plist changes. However, one fix to a typo in pkg-plist was needed.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-20 13:03:20 UTC
Thanks Euan!

Just a note that it's still preferable to 'confirm' that the change has passed QA, no matter how small the change, as even minor (two line) version updates can cause issues that are not identified until package or run time.
Comment 2 Euan Thoms 2016-01-20 13:55:41 UTC
(In reply to Kubilay Kocak from comment #1)

Noted. I always test build with DEVELOPER=yes, do a 'make check-plist' and I'm running the new version in production since just before I submitted the PR.

In future, will a Poudriere test build log suffice? Or is there more to QA. I was under the impression that the committer would have to do a Poudriere test build as a matter of course. If I could save him/her time, I would be more than happy to.
Comment 3 Euan Thoms 2016-01-20 14:01:19 UTC
(In reply to Euan Thoms from comment #2)

While on the subject. With regard to Poudriere. I was wondering if it does any testing of the various permutations of the port options? When I do my port development I test it with a regular 'make check-plist' with at least (i) default port options (ii) no options turned on (iii) all options turned on. If it's a new port, I'll try to test all permutations (which of course is very tedious). This is mostly for pkg-plist issues, which are in my experience the things that slip past QC the most often.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-20 14:02:50 UTC
(In reply to Euan Thoms from comment #3)

No need for logs (urls or attachments), just mention its been tested in your issue description, so it's not a question. Something like:

portlint: OK
testport: OK (poudriere: <versions>, <archs> tested)

Thanks again!
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-20 14:04:36 UTC
(In reply to Euan Thoms from comment #3)

That's more testing than most do, so using your best judgment is perfectly ok, given the context of the change.

Also, swills@ has written up this lovely script, which you may find useful:

http://meatwad.mouf.net/~swills/combinations.py
Comment 6 Euan Thoms 2016-01-20 14:10:53 UTC
(In reply to Kubilay Kocak from comment #5)

Thanks, I'll take a look at it some time.
Comment 7 Euan Thoms 2016-01-20 16:22:30 UTC
All tests PASS.

portlint -AC: PASS
make check-plist: PASS
poudriere testport: PASS on 10.1amd64
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-20 16:31:08 UTC
You rock Euan!
Comment 9 commit-hook freebsd_committer 2016-01-20 19:45:35 UTC
A commit references this bug:

Author: pi
Date: Wed Jan 20 19:44:59 UTC 2016
New revision: 406799
URL: https://svnweb.freebsd.org/changeset/ports/406799

Log:
  net/opensips: 2.1.1 -> 2.1.2

  Changes:
    http://opensips.org/pub/opensips/2.1.2/ChangeLog

  PR:		206431
  Submitted by:	Euan Thoms <euan@potensol.com> (maintainer)

Changes:
  head/net/opensips/Makefile
  head/net/opensips/distinfo
  head/net/opensips/pkg-plist
Comment 10 Kurt Jaeger freebsd_committer 2016-01-20 19:47:49 UTC
Committed, thanks.