Monte Carlo X-ray tracing package for simulating x-ray scattering experiments. This port contains the McXtrace kernel.
Created attachment 165975 [details] shar archive conaining the actual port forgot to attach this in the original PR
- You should create links from port's Makefile and include them into plist as regular files. With that, you won't need install and deinstall scripts - @dir entries are only needed for empty directories - you don't need @dir's for this port - You should probably also link manpages
Created attachment 186929 [details] shar archive containing new version of the port the mcxtrace kernel I've tested teh port using poudriere on 10.4 and 11.1 on i386 as well as amd64, and it installs OK. Some compiler warnings that need to be dealt with upstream.
(In reply to Dmitry Marakasov from comment #2) ...sorry for taking this absurdly long to respond. changes as sugegsted: - links to executables created and added to pkg-plist - install and deinstall scripts removed - @dir entries in pkg-plist removed The suggested links to man pages were not created done due to an upstream issue - which will be fixed in the next version.
Created attachment 186948 [details] shar archive containing new version of the port the mcxtrace kernel Found a misprint in the URL
Thank you for your submission. These changes are needed: * Please delete 'Created by' - these tags are obsolete * Rename PORTVERSION to DISTVERSION * LICENSE_FILE needs to be added * License file is named LGPL, so the license is LGPLXX * cmake needs to be changed to cmake:outsource (this is a default now) * MANDIRS= needs a tab after it * typo: designig -> designing Thanks! Yuri
Created attachment 188226 [details] archive of port of the mcxtrace kernel latest this fixes the 6 things that yuri kindly mentioned
(In reply to Yuri Victorovich from comment #6) These things are now fixed in the latest veriosn of the port
(In reply to Erik B Knudsen from comment #8) Thank you for fixing them!
Created attachment 188250 [details] Updated shar Why are .c/.h files installed?
(In reply to Yuri Victorovich from comment #10) This program works by generating (piecing together) a monolithic c-file for each specific scattering simulation. The .c and .h files are included bit by bit as needed - that's why they need to be present/installed. I can go more into detail if you want.
(In reply to Erik B Knudsen from comment #11) Thanks! I just wanted to confirm if this isn't an accidental mistake.
Committed with some changes. Thank you for your contribution!
A commit references this bug: Author: yuri Date: Tue Dec 5 19:15:50 UTC 2017 New revision: 455608 URL: https://svnweb.freebsd.org/changeset/ports/455608 Log: New port: science/mcxtrace: Monte Carlo X-ray tracing package PR: 206505 Submitted by: Erik B Knudsen <erkn@fysik.dtu.dk> Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D13216 Changes: head/science/Makefile head/science/mcxtrace/ head/science/mcxtrace/Makefile head/science/mcxtrace/distinfo head/science/mcxtrace/files/ head/science/mcxtrace/files/patch-cmake_Modules_InstallMCCODE.cmake head/science/mcxtrace/pkg-descr head/science/mcxtrace/pkg-plist