Created attachment 166168 [details]
my script to update the boot blocks
I updated to r294822 today, and did my usual make -DNO_CLEAN -j 20 buildworld buildkernel, and when done, make installworld installkernel && etcupdate && ~ler/bin/update_boot.sh (which I'll attach).
When I rebooted, I came home to find it at an OK prompt, because it couldn't find /boot/kernel.
Rebooting, it didn't use the ZFS enabled loader.
I got the current memstick image snapshot from 1/21/2016, and replaced the gptzfsboot with that one, and we boot fine.
Created attachment 166169 [details]
GOOD gptzfsboot from the snapshot
Created attachment 166170 [details]
BAD gptzfsboot from buildworld
previous build was r294058
I can confirm. Latest snapshot, r294499 works fine, however, r294908 does not. I haven't had time to minimize the window further yet.
The loader can't find the kernel.
I did a quick bisect of the change, r294750 still works, however r294770 is broken. imp@ did a series of commits, r294765 - r294769 that's most likely the culprit, although I haven't tried to narrow down exactly which commit.
(In reply to Niclas Zeising from comment #5)
That's what I get for pressing save too soon...
I added imp@ to the CC list of this PR, hopefully he'll see this.
It would be really useful if you could narrow down which of these causes the issue.
The problem appears to be that in r294765 a common paths.h was introduced, and it accidentally set the loader to be used to /boot/loader instead of /boot/zfsloader
It is being fixed now.
Sounds good. I didn't have time to narrow it further, I'm afraid. I will continue with the bisection later unless the issue is already fixed.
Just about to push a fix.
A commit references this bug:
Date: Wed Jan 27 16:36:19 UTC 2016
New revision: 294925
Fix mistake when transitioning to the new defines with ZFS loader. I
hate adding yet another define, but it is the lessor of the evil
choices available. Kill another evil by removing PATH_BOOT3 and
replacing it with PATH_LOADER or PATH_LOADER_ZFS as appropriate.
confirmed good at r294926