Bug 206702 - audio/audacity: strip binary
Summary: audio/audacity: strip binary
Status: Closed DUPLICATE of bug 206694
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2016-01-28 06:01 UTC by Jack
Modified: 2016-02-02 10:12 UTC (History)
3 users (show)

See Also:
xxjack12xx: maintainer-feedback+
koobs: merge-quarterly?

Attachments
strip binary (393 bytes, text/plain)
2016-01-28 06:01 UTC, Jack 		xxjack12xx: maintainer-approval+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2016-01-28 06:01:48 UTC 
Created attachment 166224 [details]
strip binary

Fix the warning about binary not stripped
Comment 1 Jack 2016-01-28 06:17:24 UTC 
root@jlow:/usr/ports/audio/audacity # make stage-qa
====> Running Q/A tests (stage-qa)
/!\ To run stage-qa automatically add DEVELOPER=yes to your environment /!\
root@jlow:/usr/ports/audio/audacity #
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-28 06:22:16 UTC 
Don't forget to set maintainer-approval on attachments for ports you are maintainer of :)
Comment 3 Jack 2016-01-28 06:23:02 UTC 
Keep forgetting.
Comment 4 Tatsuki Makino 2016-01-29 06:58:27 UTC 
Perhaps, stripped binary is overwritten by not stripped binary.
For example, line 8187 in attachment 166261 [details] is stripping and installing binary. And line 8206 in attachment 166261 [details] is installing binary copied before stripping.
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2016-01-30 17:25:10 UTC 
This does not build on stable/10 with all OPTIONs deselected. Could you double-check the patch?
Comment 6 Jack 2016-01-31 04:39:58 UTC 
Trying to find out why currently.
Comment 7 Jack 2016-01-31 05:08:18 UTC 
Turns out the disabling of MIDI is preventing it from compiling. Can you remove the MIDI things from the Makefile? I have another bug that adds lv2 support that will conflict with the patch if I try to make another patch.


-OPTIONS_DEFINE=        NLS DEBUG DOCS FFMPEG FLAC ID3TAG LADSPA LAME MAD MIDI \
+OPTIONS_DEFINE=        NLS DEBUG DOCS FFMPEG FLAC ID3TAG LADSPA LAME MAD \
                SBSMS SOUNDTOUCH TWOLAME VAMP VORBIS VST
-OPTIONS_DEFAULT=       FLAC ID3TAG LADSPA MAD MIDI \
+OPTIONS_DEFAULT=       FLAC ID3TAG LADSPA MAD \
                        SBSMS SOUNDTOUCH TWOLAME VAMP VORBIS VST
-MIDI_CONFIGURE_WITH=   midi
-
Comment 8 Jack 2016-02-02 10:11:53 UTC 
I couldn't make a new patch without conflicting the Makefile so I just updated 206694 with the strip binary fix.
Comment 9 Jack 2016-02-02 10:12:13 UTC 

*** This bug has been marked as a duplicate of bug 206694 ***