Created attachment 166349 [details] patch Changes: http://radare.today/posts/radare-0-10-0/ portlint: OK poudriere on 11a, 10.2a+i, 9.3a OK
I will look at this very soon. -Alex
Repoerter is Committer, assign accordingly
Approved. -Alex
A commit references this bug: Author: pi Date: Tue Feb 2 06:20:12 UTC 2016 New revision: 407796 URL: https://svnweb.freebsd.org/changeset/ports/407796 Log: devel/radare2: 0.9.9 -> 0.10.0 Changes: http://radare.today/posts/radare-0-10-0/ PR: 206793 Approved by: Alex Wilkinson <torres.73a@gmail.com> (maintainer) Changes: head/devel/radare2/Makefile head/devel/radare2/distinfo head/devel/radare2/files/patch-CVE-2015-2331 head/devel/radare2/files/patch-shlr_Makefile head/devel/radare2/pkg-plist
I know this is already approved and commited, but as an afterthought, does this port have to conflict with capstone ports? It doesn't look like they overlap in provided files.
Yes, if capstone is installed, the build uses the wrong include files and fails to build.
(In reply to Kurt Jaeger from comment #6) I think we should revise this. The problem this introduces is that there is no way to use capstone if radare is installed, other than compiling it manually and having it in a non standard location. capstone is a general purpose framework and is not limited to just radare. If no one has any objections or concerns I can prepare a patch that adds (actually revives) an option for this port to be built against system capstone or bundled version of capstone.
(In reply to oleksii.tsai from comment #7) Yes, this should be fixed. radare2 brings its own version of capstone, right now. It would be much better if it uses the port. Similar with zip and other libs it has in shlr/.
Agree! -Alex