Bug 206903 - shells/bash: Patch making iconv disconnected from NLS option
Summary: shells/bash: Patch making iconv disconnected from NLS option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-04 01:04 UTC by Yuri Victorovich
Modified: 2016-06-28 07:28 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments
patch (556 bytes, patch)
2016-02-04 01:04 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2016-02-04 01:04:21 UTC
Created attachment 166528 [details]
patch

The attached patch makes USES=iconv permanent, instead of being only for NLS=on case.

The reason is that NLS is related to message translations to different languages.
And bash has the general feature that \uNNNN is translated into the unicode character using iconv. This is unicode support, and should have nothing to do with translations.

bash also currently has a bug that --disable-nls causes it to fail to find iconv. I  reported this bug to bash-devel ML. So in the future, when bash will fix this, this patch will make a difference.
Comment 1 commit-hook freebsd_committer 2016-06-28 07:28:15 UTC
A commit references this bug:

Author: ehaupt
Date: Tue Jun 28 07:28:02 UTC 2016
New revision: 417697
URL: https://svnweb.freebsd.org/changeset/ports/417697

Log:
  [1] Make USES=iconv permanent, instead of being only for NLS=on case.

      The reason is that NLS is related to message translations to different
      languages.

      And bash has the general feature that \uNNNN is translated into the unicode
      character using iconv. This is unicode support, and should have nothing to
      do with translations.

      bash also currently has a bug that --disable-nls causes it to fail to find
      iconv. This bug has been reported upstream to bash-devel ML. In the future,
      when bash will fix this, this will make a difference.

      Note that this uses iconv from libc.

  [2] Update to 4.3.46

  PR:             206903 [1], 210620 [2]
  Submitted by:   yuri@rawbw.com [1], pkubaj@anongoth.pl [2]
  Discussed with: adamw

Changes:
  head/shells/bash/Makefile
  head/shells/bash/distinfo
Comment 2 Emanuel Haupt freebsd_committer 2016-06-28 07:28:57 UTC
Committed, thanks!