Bug 206944 - databases/sqlite3: Enable one of the command line editing options
Summary: databases/sqlite3: Enable one of the command line editing options
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-02-05 07:17 UTC by Tobias Kortkamp
Modified: 2016-02-11 20:03 UTC (History)
2 users (show)

See Also:
pavelivolkov: maintainer-feedback+


Attachments
sqlite3.diff (527 bytes, patch)
2016-02-05 07:17 UTC, Tobias Kortkamp
pi: maintainer-approval-
Details | Diff
Poudriere testport log FreeBSD 10.2/amd64 (27.46 KB, text/x-log)
2016-02-05 07:26 UTC, Tobias Kortkamp
no flags Details
use of the system's readline library by default (1.43 KB, patch)
2016-02-05 13:14 UTC, Pavel Volkov
pavelivolkov: maintainer-approval+
Details | Diff
log file for this a port (15.67 KB, text/plain)
2016-02-05 13:17 UTC, Pavel Volkov
no flags Details
portlint log file for this port (20.97 KB, text/plain)
2016-02-05 13:17 UTC, Pavel Volkov
no flags Details
use of the system's readline library by default, increment PORTREVISION (1.72 KB, patch)
2016-02-05 13:21 UTC, Pavel Volkov
pavelivolkov: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2016-02-05 07:17:06 UTC
Created attachment 166604 [details]
sqlite3.diff

The last update to sqlite3 disabled readline support :-(

Can we enable one of the command line editing option again?  Without it interactive use of sqlite3 is pretty bad.

The attached patch enables the EDITLINE option by default.
Comment 1 Tobias Kortkamp freebsd_committer 2016-02-05 07:26:23 UTC
Created attachment 166605 [details]
Poudriere testport log FreeBSD 10.2/amd64
Comment 3 Pavel Volkov 2016-02-05 13:14:17 UTC
Created attachment 166611 [details]
use of the system's readline library by default

Hello. I'm sorry.
I forget about packages with default options.
Someone uses them, it's amazing. I apologize.
Don't you mind about use of the readline library from the system?
To avoid unnecessary dependencies.
Thank you very much.
Comment 4 Pavel Volkov 2016-02-05 13:17:02 UTC
Created attachment 166612 [details]
log file for this a port
Comment 5 Pavel Volkov 2016-02-05 13:17:36 UTC
Created attachment 166613 [details]
portlint log file for this port
Comment 6 Pavel Volkov 2016-02-05 13:21:41 UTC
Created attachment 166614 [details]
use of the system's readline library by default, increment PORTREVISION

I'm sorry. PORTREVISION increment, of course.
Comment 7 Kurt Jaeger freebsd_committer 2016-02-11 19:36:03 UTC
Comment on attachment 166604 [details]
sqlite3.diff

Maintainer provided a different patch.
Comment 8 Kurt Jaeger freebsd_committer 2016-02-11 19:36:25 UTC
Testbuilds@work
Comment 9 Kurt Jaeger freebsd_committer 2016-02-11 19:58:40 UTC
Testbuilds are fine. Portlint is okeyish, too.

Is this a topic that needs work ?

WARN: Makefile: UNICODE61 is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MUNICODE61 appears.
Comment 10 commit-hook freebsd_committer 2016-02-11 20:00:48 UTC
A commit references this bug:

Author: pi
Date: Thu Feb 11 20:00:36 UTC 2016
New revision: 408698
URL: https://svnweb.freebsd.org/changeset/ports/408698

Log:
  databases/sqlite3: Enable one of the command line editing options

  - The last update to sqlite3 disabled readline support
  - Now several variants can be selected.

  PR:		206944
  Submitted by:	Tobias Kortkamp <t@tobik.me>
  Approved by:	Pavel Volkov <pavelivolkov@gmail.com> (maintainer)

Changes:
  head/databases/sqlite3/Makefile
Comment 11 Kurt Jaeger freebsd_committer 2016-02-11 20:03:00 UTC
Committed, thanks.