diffoscope invokes the command `readelf --wide --string-dump=.comment ls.b`, but readelf from GNU binutils 2.17.50 does not support --string-dump. It should probably require the binutils port and use readelf from there, on stable/10 only. For 11 readelf comes from ELF Tool Chain and supports --string-dump.
I'll have a pow-wow with upstream regarding this to get their thoughts
Is there an alternative for --string-dump or is diffoscope materially less valuable without it?
At a minimum, perhaps the code could only attempt to use the argument if it detects that it's available
> Is there an alternative for --string-dump or is diffoscope materially less
> valuable without it?
I would say that it is in fact materially less valuable without --string-dump, although falling back to --hex-dump is probably sufficient (the user will get the same underlying information, just in a less useful format).
Any upstream feedback?
FreeBSD 10 is approaching EOL, we can probably just close this PR once that happens.
FreeBSD 10.x is now EoL. Apologies Ed for not being able to resolve this in time.