Bug 207081 - sysutils/py-diffoscope: Uses --string-dump arg without checking for its availability (not in binutils 2.17.50)
Summary: sysutils/py-diffoscope: Uses --string-dump arg without checking for its avail...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2016-02-10 16:02 UTC by Ed Maste
Modified: 2020-05-18 01:54 UTC (History)
0 users

See Also:
koobs: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2016-02-10 16:02:52 UTC 
diffoscope invokes the command `readelf --wide --string-dump=.comment ls.b`, but readelf from GNU binutils 2.17.50 does not support --string-dump. It should probably require the binutils port and use readelf from there, on stable/10 only. For 11 readelf comes from ELF Tool Chain and supports --string-dump.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-02-10 16:09:00 UTC 
I'll have a pow-wow with upstream regarding this to get their thoughts

Is there an alternative for --string-dump or is diffoscope materially less valuable without it?

At a minimum, perhaps the code could only attempt to use the argument if it detects that it's available
Comment 2 Ed Maste freebsd_committer freebsd_triage 2016-02-10 16:12:59 UTC 
> Is there an alternative for --string-dump or is diffoscope materially less
> valuable without it?

I would say that it is in fact materially less valuable without --string-dump, although falling back to --hex-dump is probably sufficient (the user will get the same underlying information, just in a less useful format).
Comment 3 Ed Maste freebsd_committer freebsd_triage 2016-04-13 16:00:54 UTC 
Any upstream feedback?
Comment 4 Ed Maste freebsd_committer freebsd_triage 2018-10-03 17:32:02 UTC 
FreeBSD 10 is approaching EOL, we can probably just close this PR once that happens.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2020-05-18 01:54:50 UTC 
FreeBSD 10.x is now EoL. Apologies Ed for not being able to resolve this in time.