Bug 207138 - /etc/ntp.conf claims /var/db/ntpd.leap-seconds.list is updated weekly
Summary: /etc/ntp.conf claims /var/db/ntpd.leap-seconds.list is updated weekly
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: 10.2-BETA2
Hardware: Any Any
: --- Affects Only Me
Assignee: Ian Lepore
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-12 21:01 UTC by Trond Endrestøl
Modified: 2018-07-04 14:17 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2016-02-12 21:01:58 UTC
A comment in /etc/ntp.conf claims /var/db/ntpd.leap-seconds.list is updated weekly, whereas it's updated daily by 480.leapfile-ntpd in /etc/periodic/daily, if enabled.
Comment 1 Vick Khera 2016-10-13 13:07:14 UTC
The default rc.conf variable ntp_leapfile_expiry_days is set to 30, so it is only fetched once every 30 days even though it is checked daily. Still, the comment is incorrect about it being weekly.
Comment 2 Vick Khera 2016-10-13 13:12:56 UTC
Actually, to correct myself, it will check the file expire date daily, and if it is within 30 days (as configured) of that date it will fetch a new one. So in practice this happens once every few months.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-06-24 03:31:36 UTC
A commit references this bug:

Author: ian
Date: Sun Jun 24 03:31:23 UTC 2018
New revision: 335596
URL: https://svnweb.freebsd.org/changeset/base/335596

Log:
  Fix a comment; the ntp leaplist file is updated periodically, but not weekly
  (it's only updated when a check shows it's within 30 days of expiring).

  PR:		207138

Changes:
  head/etc/ntp.conf
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-07-04 14:05:19 UTC
A commit references this bug:

Author: ian
Date: Wed Jul  4 14:04:23 UTC 2018
New revision: 335949
URL: https://svnweb.freebsd.org/changeset/base/335949

Log:
  MFC r335595-r335596

  r335595:
  Modernize usage of "restrict" keyword in ntp.conf

  It is no longer necessary to specify a -4/-6 flag on any ntp.conf
  keyword.  The address type is inferred from the address itself as
  necessary.  "restrict default" statements always apply to both address
  families regardless of any -4/-6 flag that may be present.

  So this change just tidies up our default config by removing the redundant
  restrict -6 statement and comment, and by removing the -6 flag from the
  restrict keyword that allows access from localhost.

  This change was inspired by the patches provided in PRs 201803 and 210245,
  and included some contrib/ntp code inspection to verify that the -4/-6
  keywords are basically no-ops in all contexts now.

  PR:		201803 210245
  Differential Revision:	https://reviews.freebsd.org/D15974

  r335596:
  Fix a comment; the ntp leaplist file is updated periodically, but not weekly
  (it's only updated when a check shows it's within 30 days of expiring).

  PR:		207138

Changes:
_U  stable/11/
  stable/11/etc/ntp.conf
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-07-04 14:11:29 UTC
A commit references this bug:

Author: ian
Date: Wed Jul  4 14:10:36 UTC 2018
New revision: 335950
URL: https://svnweb.freebsd.org/changeset/base/335950

Log:
  MFC r335595-r335596

  r335595:
  Modernize usage of "restrict" keyword in ntp.conf

  It is no longer necessary to specify a -4/-6 flag on any ntp.conf
  keyword.  The address type is inferred from the address itself as
  necessary.  "restrict default" statements always apply to both address
  families regardless of any -4/-6 flag that may be present.

  So this change just tidies up our default config by removing the redundant
  restrict -6 statement and comment, and by removing the -6 flag from the
  restrict keyword that allows access from localhost.

  This change was inspired by the patches provided in PRs 201803 and 210245,
  and included some contrib/ntp code inspection to verify that the -4/-6
  keywords are basically no-ops in all contexts now.

  PR:		201803 210245
  Differential Revision:	https://reviews.freebsd.org/D15974

  r335596:
  Fix a comment; the ntp leaplist file is updated periodically, but not weekly
  (it's only updated when a check shows it's within 30 days of expiring).

  PR:		207138

Changes:
_U  stable/10/
  stable/10/etc/ntp.conf