Bug 207191 - x11/leechcraft: Unmark MAKE_JOBS_UNSAFE.
Summary: x11/leechcraft: Unmark MAKE_JOBS_UNSAFE.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Veniamin Gvozdikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-14 20:24 UTC by Raphael Kubo da Costa
Modified: 2016-03-23 23:29 UTC (History)
2 users (show)

See Also:
rakuco: maintainer-feedback-


Attachments
Proposed patch (352 bytes, patch)
2016-02-14 20:24 UTC, Raphael Kubo da Costa
rakuco: maintainer-approval? (vg)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-02-14 20:24:23 UTC
Created attachment 166993 [details]
Proposed patch

I've just built x11/leechcraft with -j56 on Poudriere, and it worked fine. I'm tempted to believe whatever problems there were when the port was initially added to the tree have since been solved, and the port should be make jobs safe now.
Comment 1 John Marino freebsd_committer freebsd_triage 2016-03-23 22:50:33 UTC
wow, I was jus going to open a PR like this one.

Leechcraft is the very last port to build when I do the entire tree, because it takes 90 minutes to build.

With this slow c++, if it's really jobs safe, we need to remove this MAKE_JOBS_UNSAFE flag.   Please.  ASAP.
Comment 2 John Marino freebsd_committer freebsd_triage 2016-03-23 22:51:30 UTC
rakuco, this PR times out 2 weeks ago, so technically you can commit it now.
Comment 3 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-03-23 23:24:58 UTC
I had totally forgotten about this PR.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-03-23 23:26:23 UTC
A commit references this bug:

Author: rakuco
Date: Wed Mar 23 23:26:19 UTC 2016
New revision: 411745
URL: https://svnweb.freebsd.org/changeset/ports/411745

Log:
  Drop MAKE_JOBS_UNSAFE.

  The port built fine with -j56 on Poudriere, and it also ran fine. I'm tempted
  to believe whatever problems there were when the port was initially added to
  the tree have since been solved, and the port should be make jobs safe now.

  PR:		207191
  Approved by:	maintainer timeout (vg, 39 days)

Changes:
  head/x11/leechcraft/Makefile
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-03-23 23:29:24 UTC
A commit references this bug:

Author: rakuco
Date: Wed Mar 23 23:28:22 UTC 2016
New revision: 411746
URL: https://svnweb.freebsd.org/changeset/ports/411746

Log:
  MFH: r411745

  Drop MAKE_JOBS_UNSAFE.

  The port built fine with -j56 on Poudriere, and it also ran fine. I'm tempted
  to believe whatever problems there were when the port was initially added to
  the tree have since been solved, and the port should be make jobs safe now.

  PR:		207191
  Approved by:	maintainer timeout (vg, 39 days)

  Approved by:	portmgr blanket approval

Changes:
_U  branches/2016Q1/
  branches/2016Q1/x11/leechcraft/Makefile