Created attachment 167034 [details] Patch adds Phabricator support to SeeAlso Field respecting upstream
Hi Mahdi, I just notice there is no OPTION to install the extensions, so I have to write and test first some additions to the ports Makefile and pkg-plist. Will take some time because we have to find out first all BUILD/RUN dependencies for every singe extension and include them into the build.
(In reply to Olli Hauer from comment #2) You mean currently no default-extension are gonna installed when we install bugzilla ?
(In reply to Mahdi Mokhtari from comment #3) Yes, with the current port no extension will be installed ... Somewhere I missed the extensions during the bugzilla50 port creation. I will create new OPTIONS for BmpConvert, Example, MoreBugUrl, OldBugMove and Voting The port was written based on beta1, I have to admit I've only read the rel notes but have never looked if the source contains additional files.
(In reply to Olli Hauer from comment #4) Okay. If you're busy i can create OPTIONS and leave review for you. Just for emphasizing, these special extensions are parts of Bugzilla and it maybe doesn't work correctly if they wont be installed. (just as what happened in issue#207213)
Created attachment 167045 [details] patch for Phabricator and add option for MOREBUGURL and VOTING The new patch contains OPTIONS to install MOREBUGURL and Voting. It seems there is a possible tarpit (but I cannot test/verfy on a BZ installation the next days) Inside an extension dir there is an empty file "disabled", to activate the module the file has to be removed to activate the extension but will be installed again during the next update. If we do not install the empty "disabled" file it is possible someone installs BZ and the extension is activated without notice ... (It happened once to a user that Vote was installed and activated, so during the next checksetup the database schema was extended) If it is possible for you plz. test the new patch.
(In reply to Olli Hauer from comment #6) Portlint: Okay. Poudriere: Okay. Run in my bugzilla local machine: seems Okay too
Can you test to enable the extensions and what happens if the "disabled" file will be recreated. - dump database (save copy) - activate extension, for example vote - create a bug entry with votes - recreate the "disabled" file - run checksetup - re-test the bug ID with the extension In case there are issues we have to fix them first to be sure no damage happens on the user site or on the FreeBSD instance.
(In reply to Olli Hauer from comment #8) Okay, I'm gonna testing these on my machine installation. I'll inform you on results here.
(In reply to Olli Hauer from comment #8) Sorry for delay :) This scenario works for MoreBugURL extension (MoreBugURL test: Okay) I'm going to test for Voting extension too
(In reply to Olli Hauer from comment #8) Voting tested too. - activate extension, for example vote -> Okay - create a bug entry with votes -> Okay - recreate the "disabled" file -> Okay - re-enabled -> Okay and data not lost :D - run checksetup in all stages -> Okay
No we have: portlint: Okay poudriere: Okay (9.3 10.1 11.0) Module tested: Okay. @Olli: up to you now mate ! :D
A commit references this bug: Author: ohauer Date: Tue Feb 16 19:35:37 UTC 2016 New revision: 409014 URL: https://svnweb.freebsd.org/changeset/ports/409014 Log: - add new OPTIONS_GROUP_EXTENSIONS (MoreBugUrl and Voting) - add patch so MoreBugUrl has support for Phabricator URL's [1] - PORTREVISION bump not requied, new OPTIONS are OFF by default [1] Upstream PR: https://bugzilla.mozilla.org/show_bug.cgi?id=1128119 Special Thanks goes to Mahdi Mokhtari for the patches and improving the FreeBSD Bugzilla integration! PR: 207216 Submitted by: Mahdi Mokhtari Changes: head/devel/bugzilla50/Makefile head/devel/bugzilla50/Makefile.options head/devel/bugzilla50/files/patch-PR207213 head/devel/bugzilla50/pkg-plist
(In reply to Mahdi Mokhtari from comment #12) It's committed, thanks for the additional testing!