Bug 207437 - lang/phantomjs -- Allow building without SSLv3
Summary: lang/phantomjs -- Allow building without SSLv3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthew Seaman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-23 10:08 UTC by Matthew Seaman
Modified: 2016-05-15 10:05 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (kuriyama)


Attachments
Patches to enable compilation in a no-SSLv3 environment (3.33 KB, patch)
2016-02-23 10:08 UTC, Matthew Seaman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Seaman freebsd_committer 2016-02-23 10:08:59 UTC
Created attachment 167320 [details]
Patches to enable compilation in a no-SSLv3 environment

Add a couple of patch files that enable phantomjs to build in the case where
USE_OPENSSL_PORTS=yes is set, and OpenSSL is configured not to support SSLv3.

While this is an unusual configuration at the moment, I believe it is due to become the default at some point.  It should also allow linking against eg. LibreSSL which doesn't support SSLv3 at all -- although this I have no tested.

Compiles happily according to poudriere testport and has been in use locally with these modifications and without any reports of problems.
Comment 1 commit-hook freebsd_committer 2016-05-15 10:05:04 UTC
A commit references this bug:

Author: matthew
Date: Sun May 15 10:04:12 UTC 2016
New revision: 415226
URL: https://svnweb.freebsd.org/changeset/ports/415226

Log:
  Add support for compiling in a no-SSLv3 environment.

  PR:		207437
  Submitted by:	matthew
  Approved by:	maintainer-timeout (kuriyama, >90days)

Changes:
  head/lang/phantomjs/Makefile
  head/lang/phantomjs/files/patch-src_qt_qtbase_src_network_ssl_qsslcontext.cpp
  head/lang/phantomjs/files/patch-src_qt_qtbase_src_network_ssl_qsslsocket__openssl__symbols.cpp