Bug 207528 - mail/mailman remove postfix dependency and fix pkg-install.in script
Summary: mail/mailman remove postfix dependency and fix pkg-install.in script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-26 19:03 UTC by Olli Hauer
Modified: 2016-03-01 00:13 UTC (History)
1 user (show)

See Also:


Attachments
[patch] remove postfix dependency (411 bytes, text/plain)
2016-02-26 19:03 UTC, Olli Hauer
mandree: maintainer-approval-
Details
[patch] fix pkg-install.in (679 bytes, text/plain)
2016-02-26 19:05 UTC, Olli Hauer
mandree: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Hauer freebsd_committer 2016-02-26 19:03:52 UTC
Created attachment 167454 [details]
[patch] remove postfix dependency

The first patch removes postfix as build and run dependency so users are free to choose the postfix version without being afraid it will be replaced during the next pkg upgrade.
I found no reason to handle postfix different the sendmail, opensmtpd and exim.

The second patch corrects pkg-install, else it will create a "-g" and mailman directory in the portsdir.

$ make package
$ pkg install work/pkg/mailman-2.1.20_2.txz
$ ls -1
-g  <== this
Makefile
distinfo
files
mailman <== and this directory is created by installing the port
pkg-descr
pkg-plist
work
Comment 1 Olli Hauer freebsd_committer 2016-02-26 19:05:16 UTC
Created attachment 167455 [details]
[patch] fix pkg-install.in

This is the second patch fixing the install instruction
Comment 2 Matthias Andree freebsd_committer 2016-02-29 23:48:48 UTC
Comment on attachment 167455 [details]
[patch] fix pkg-install.in

will take the install fix patch, but not the dependency removal.
Comment 3 commit-hook freebsd_committer 2016-03-01 00:06:10 UTC
A commit references this bug:

Author: mandree
Date: Tue Mar  1 00:05:09 UTC 2016
New revision: 409836
URL: https://svnweb.freebsd.org/changeset/ports/409836

Log:
  Fix pkg-install "install -d" invocation.

  It used to use GNU-install-isms (options after arguments) that don't
  work with BSD install and caused two spurious directories to be created,
  one named -g, the other usually named "mailman" (or whichever group name
  was configured).  Bumps PORTREVISION.

  PR:		207528 (Attachment #167455 [details])
  Submitted by:	ohauer@

Changes:
  head/mail/mailman/Makefile
  head/mail/mailman/files/pkg-install.in
Comment 4 Matthias Andree freebsd_committer 2016-03-01 00:12:49 UTC
I believe after the recent mail/postfix* port upgrades, the "remove postfix dependency" should no longer matter. I think that binary packages should do the right thing; for a compromise, I would however accept an invisible build option that changes the Postfix dependency to some other, or an option change to make no MTA integration adjustments.