Bug 207628 - dns/fastresolve: [maintainer] eliminate Bus error/segmentation fault/core dump
Summary: dns/fastresolve: [maintainer] eliminate Bus error/segmentation fault/core dump
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-03-01 22:21 UTC by Chris Hutchinson
Modified: 2016-03-02 17:02 UTC (History)
2 users (show)

See Also:
portmaster: maintainer-feedback+

Attachments
svn diff for dns/fastresolve (patch) (1.34 KB, patch)
2016-03-01 22:21 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2016-03-01 22:21:41 UTC 
Created attachment 167617 [details]
svn diff for dns/fastresolve (patch)

pr 207589 was raised, which indicated that dns/fastresolve
would build, but usage resulted in a core dump.
The attached svn diff adds an additional patch file,
that eliminates this error.
This and additional work will be incorporated into the
source itself in the upcoming version. But until then,
I think this solution should be incorporated now into
this version.

Changes
PROTREVISION
the addition of:
files/patch-dns-terror_BoolString.h

That's it!

A big thanks to  Miroslav Lachman, for reporting, and
invaluable feedback, and to  Dan Lukes, for suggesting,
and providing the intermediate solution!

Thanks!

--Chris
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-03-02 07:58:32 UTC 
A commit references this bug:

Author: pi
Date: Wed Mar  2 07:58:13 UTC 2016
New revision: 409915
URL: https://svnweb.freebsd.org/changeset/ports/409915

Log:
  dns/fastresolve: fix segfault

  PR:		207589, 207628
  Submitted by:	Miroslav Lachman <000.fbsd@quip.cz>, Dan Lukes <dan@obluda.cz>, Chris Hutchinsin <portmaster@bsdforge.com> (maintainer)

Changes:
  head/dns/fastresolve/Makefile
  head/dns/fastresolve/files/patch-dns-terror_BoolString.h
  head/dns/fastresolve/files/patch-dns-terror__DatedStringDb.cc
  head/dns/fastresolve/files/patch-dns-terror__dns-terror.cc
  head/dns/fastresolve/files/patch-dns-terror_getline.c
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2016-03-02 08:09:02 UTC 
Committed, thanks. Please note that having one PR for this would be sufficient.
Comment 3 Chris Hutchinson 2016-03-02 17:02:32 UTC 
(In reply to Kurt Jaeger from comment #2)
> Committed, thanks. Please note that having one PR for this would be
> sufficient.

Got it.

Thanks you very much, Kurt, for such a quick response!

--Chris