Bug 207910 - [uart] [patch] fix for Intel Atom Cherryview SOC HSUART not recognized
Summary: [uart] [patch] fix for Intel Atom Cherryview SOC HSUART not recognized
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: amd64 Any
: --- Affects Some People
Assignee: freebsd-bugs mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-03-11 18:55 UTC by Johannes Lundberg
Modified: 2018-02-27 13:42 UTC (History)
4 users (show)

See Also:


Attachments
Patch to add PCI IDs for HSUART on Intel Atom SOC (904 bytes, patch)
2016-03-11 18:55 UTC, Johannes Lundberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Lundberg 2016-03-11 18:55:44 UTC
Created attachment 168020 [details]
Patch to add PCI IDs for HSUART on Intel Atom SOC

HSUART devices not recognized on Intel Atom Cherry Trail SOCs. 

As a consequence boot halts during uart.1 initialization unless disabled or commented out in the default device.hints.

The attached patch adds PCI IDs for 0x228a8086 and 0x228c8086 to uart_bus_pci.c.

HSUART#1 is tested and seem to function normally.
HSUART#2 is not tested.
Comment 1 Johannes Lundberg 2016-03-11 19:46:18 UTC
Additional info from atom-z8000-datasheet-vol-1.pdf

I think this SOC only has only one UART (integrated into the PCU) but two Serial I/O HSUARTs. 

The UART (uart.0) works with current 3F8h, IRQ4 settings.

The hint.uart.1.* settings from device.hints must be removed for this SOC since uart1 and uart2 devices will be SIO High Speed UARTs.
Comment 2 Sean Bruno freebsd_committer 2016-11-20 19:29:54 UTC
I'll fire this into current directly.
Comment 3 commit-hook freebsd_committer 2016-11-21 14:43:49 UTC
A commit references this bug:

Author: sbruno
Date: Mon Nov 21 14:43:31 UTC 2016
New revision: 308926
URL: https://svnweb.freebsd.org/changeset/base/308926

Log:
  Add Intel Atom Cherryview SOC HSUART support

  PR:	207910
  Submitted by:	johannes@brilliantservice.co.jp
  MFC after:	1 week

Changes:
  head/sys/dev/uart/uart_bus_pci.c
Comment 4 commit-hook freebsd_committer 2018-02-11 07:04:54 UTC
A commit references this bug:

Author: eadler
Date: Sun Feb 11 07:04:48 UTC 2018
New revision: 329121
URL: https://svnweb.freebsd.org/changeset/base/329121

Log:
  MFC r308926:

  Add Intel Atom Cherryview SOC HSUART support

  PR:	207910
  Submitted by:	johannes@brilliantservice.co.jp

Changes:
_U  stable/11/
  stable/11/sys/dev/uart/uart_bus_pci.c
Comment 5 DrWho 2018-02-27 13:42:57 UTC
Hello!
Please tell me how to apply this Patch ?