Bug 207979 - [PATCH] devel/upp: Fix v9251 build, after print/freetype2 update
Summary: [PATCH] devel/upp: Fix v9251 build, after print/freetype2 update
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mark Felder
URL: https://svnweb.freebsd.org/ports?view...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-03-14 15:56 UTC by lightside
Modified: 2016-03-19 19:34 UTC (History)
3 users (show)

See Also:
m.sund: maintainer-feedback+


Attachments
Proposed patch (since 411026 revision) (968 bytes, patch)
2016-03-14 15:56 UTC, lightside
m.sund: maintainer-approval+
Details | Diff
The poudriere testport log (FreeBSD 10.2 amd64) (44.87 KB, application/x-bzip2)
2016-03-14 17:28 UTC, lightside
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2016-03-14 15:56:25 UTC
Created attachment 168158 [details]
Proposed patch (since 411026 revision)

Patch to fix the build of devel/upp port, after print/freetype2 update.

- Bump PORTREVISION
- Use simplified upstream patch [1, 2] to fix the build

Reference links:
1. Fixed FT include issue in GtkDrawText.cpp
https://github.com/ultimatepp/mirror/commit/24c443290699034e21d6bdb8b1dee493e78107c5
2. freetype include in GTK backend removed
https://github.com/ultimatepp/mirror/commit/71174caa1b99265490d1cc210e7efe0f6b325eba
Comment 1 lightside 2016-03-14 16:06:36 UTC
(In reply to comment #0)
> - Use simplified upstream patch [1, 2] to fix the build
Initially, I used regular patch in files directory, but after checking the portlint, it was required to add USES=dos2unix, because of DOS line endings in CtrlCore/GtkDrawText.cpp file, therefore I just used sed patch for it.
Comment 2 lightside 2016-03-14 17:28:42 UTC
Created attachment 168159 [details]
The poudriere testport log (FreeBSD 10.2 amd64)
Comment 3 m.sund 2016-03-19 08:04:50 UTC
Thanks, for providing the patch!
Comment 4 Mark Felder freebsd_committer 2016-03-19 19:34:47 UTC
Committed, thanks!
Comment 5 commit-hook freebsd_committer 2016-03-19 19:34:51 UTC
A commit references this bug:

Author: feld
Date: Sat Mar 19 19:34:30 UTC 2016
New revision: 411421
URL: https://svnweb.freebsd.org/changeset/ports/411421

Log:
  devel/upp: Unbreak port

  - Bump PORTREVISION
  - Use simplified upstream patch [1, 2] to fix the build

  Reference links:
  1. Fixed FT include issue in GtkDrawText.cpp
  https://github.com/ultimatepp/mirror/commit/24c443290699034e21d6bdb8b1dee493e78107c5
  2. freetype include in GTK backend removed
  https://github.com/ultimatepp/mirror/commit/71174caa1b99265490d1cc210e7efe0f6b325eba

  PR:		207979

Changes:
  head/devel/upp/Makefile