Bug 208079 - emulators/wine needs v4l_compat for properly supporting V4L option
Summary: emulators/wine needs v4l_compat for properly supporting V4L option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-17 10:17 UTC by Baptiste Daroussin
Modified: 2016-03-22 00:34 UTC (History)
1 user (show)

See Also:

Attachments
Add build dependency on multimedia/v4l_compat (439 bytes, patch)
2016-03-20 07:56 UTC, David Naylor 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Daroussin freebsd_committer freebsd_triage 2016-03-17 10:17:35 UTC 
v4l needs at build time v4l_compat to correctly support the V4L option (both in the "i386" version and the native one)

Otherwise V4L is never enabled https://github.com/wine-mirror/wine/blob/9bd963065b1fb7b445d010897d5f84967eadf75b/dlls/avicap32/avicap32_main.c#L149
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2016-03-17 10:18:44 UTC 
Cc both maintainers
Comment 2 David Naylor freebsd_committer freebsd_triage 2016-03-20 07:56:49 UTC 
Created attachment 168419 [details]
Add build dependency on multimedia/v4l_compat

Over to Gerald to approve.  I can commit this patch on your behalf if that is more convenient.
Comment 3 David Naylor freebsd_committer freebsd_triage 2016-03-20 07:58:14 UTC 
P.S. This will require a PORTREVISION bump (unless incorporated into the latest release ;-)).  This impacts all wine(-devel|-staging) ports.
Comment 4 Gerald Pfeifer freebsd_committer freebsd_triage 2016-03-20 20:47:16 UTC 
Thank you for the report, Bapt!

(In reply to David Naylor from comment #3)
> P.S. This will require a PORTREVISION bump (unless incorporated into the > latest release ;-)).

I have integrated this into my local update for emulators/wine-devel
to version 1.9.6, alas the staging project has not released there
updated patch set yet.  I plan on committing both together, hopefully
by end of Monday.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-03-22 00:23:38 UTC 
A commit references this bug:

Author: gerald
Date: Tue Mar 22 00:23:10 UTC 2016
New revision: 411629
URL: https://svnweb.freebsd.org/changeset/ports/411629

Log:
  Update to Wine 1.9.6.  This includes the following changes:
   - Better video card detection when using Mesa.
   - Support for Shader Model 5 shaders.
   - C++ exception handling improvements.
   - Various bug fixes.

  Add the multimedia/v4l_compat port as a build dependency for V4L
  (i.e., V4L_BUILD_DEPENDS). [1]

  PR:		208079 [1]
  Submitted by:	dbn [1]
  Reported by:	bapt [1]

Changes:
  head/emulators/wine-devel/Makefile
  head/emulators/wine-devel/distinfo
  head/emulators/wine-devel/pkg-plist
Comment 6 Gerald Pfeifer freebsd_committer freebsd_triage 2016-03-22 00:34:48 UTC 
This should be resolved now.  Please advise should this be not the case.