Created attachment 168338 [details]
Fix subshell disabled problem for SHELL=/bin/csh
While implementing "Support for ash + bugfixes for bash, fish (#2742)" the /bin/csh was forgotten and no subshell working in mc. When you press Ctrl-o pannels are disappearing, but csh command prompt is not there.
The problem is in treating the /bin/csh as symlink to /bin/tcsh, which actually is the hardlink.
The link to the ticket: https://www.midnight-commander.org/ticket/2742
The patch is attached.
Created attachment 168343 [details]
Patch from upstream ticket 2742 to fix subshell problem
I have updated the patch provided by Zmiter from upstream to be relative to the FreeBSD ports base directory, and to bump the PORTREVISION. Thanks for the bug report Zmiter.
Created attachment 168344 [details]
QA: Successful poudriere testport logs for misc/mc 4.8.16 with patch on FreeBSD 10.2 amd64
A commit references this bug:
Date: Fri Mar 18 12:04:33 UTC 2016
New revision: 411345
misc/mc: Multiple fixes
- Fix subshell functionality for csh users
- Make SFTP an option, enabled by default
- Fix SIGILL on FreeBSD 9.x
- Fix perl ls helper with fish shell
PR: 207487, 208027, 208102, 208104