Bug 208180 - Improve license dialog layout
Summary: Improve license dialog layout
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-21 13:56 UTC by Tijl Coosemans
Modified: 2016-03-21 14:36 UTC (History)
1 user (show)

See Also:

Attachments
patch (978 bytes, patch)
2016-03-21 13:56 UTC, Tijl Coosemans 		no flags Details | Diff
patch2 (969 bytes, patch)
2016-03-21 14:10 UTC, Tijl Coosemans 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer freebsd_triage 2016-03-21 13:56:22 UTC 
Created attachment 168454 [details]
patch

When you run make in print/hplip-plugin there is a license dialog.  When you select "View license" the license is displayed in a way that requires horizontal scrolling.  The attached patch combines both screens in one --yesno dialog that folds the text.
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2016-03-21 14:10:38 UTC 
Created attachment 168455 [details]
patch2

"|| exit 1" is of course redundant
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2016-03-21 14:14:54 UTC 
Now that the ${DIALOG} call is silenced, looks great, approved :-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-03-21 14:34:51 UTC 
A commit references this bug:

Author: tijl
Date: Mon Mar 21 14:34:06 UTC 2016
New revision: 411569
URL: https://svnweb.freebsd.org/changeset/ports/411569

Log:
  Replace the license dialog menu and "View license" screen with one --yesno
  dialog.  This also folds long lines.

  PR:		208180
  Approved by:	portmgr (mat)

Changes:
  head/Mk/bsd.licenses.mk