Bug 208440 - Templates/config.{guess,sub}: Revert 319948, Canonicalize amd64 as x86_64 (restores upstream behavior)
Summary: Templates/config.{guess,sub}: Revert 319948, Canonicalize amd64 as x86_64 (re...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Port Management Team
URL: http://git.savannah.gnu.org/cgit/conf...
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2016-03-31 22:23 UTC by Jan Beich
Modified: 2022-08-26 12:47 UTC (History)
4 users (show)

See Also:
koobs: exp-run?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2016-03-31 22:23:03 UTC
On FreeBSD amd64 uname -p and uname -m report amd64. GNU config canonicalizes it as x86_64. Various upstream projects may not expect amd64 in configure target triple, so ports end up overriding CONFIGURE_TARGET. This may not be easily noticible if otherwise the build doesn't break e.g., x11/babl.

Let's back out ports r319948 from *both* config.guess and config.sub.

  $ cd /path/to/config
  $ sh config.guess
  x86_64-unknown-freebsd11.0
  $ sh config.sub amd64-unknown-freebsd11.0
  x86_64-unknown-freebsd11.0

http://git.savannah.gnu.org/cgit/config.git/commit/?id=4e3da806cdd8

vs.

  $ cd /usr/ports
  $ sh Templates/config.guess
  amd64-unknown-freebsd11.0
  $ sh Templates/config.sub amd64-portbld-freebsd11.0
  amd64-portbld-freebsd11.0
Comment 1 Jan Beich freebsd_committer freebsd_triage 2016-09-08 14:32:17 UTC
Did portmgr time out itself? If there were replies off bugzilla those need to be linked here.
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2016-09-08 14:33:38 UTC
No, but there was no patch, and you did not ask for an exp-run.  Feel free to re-open this and do so.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-09-08 14:59:37 UTC
Re-open, clarifying summary. 

@Jan A patch (attachment) reverting r319948 may be more explicit for portmgr and potentially easier to exp-run for antoine
Comment 4 Baptiste Daroussin freebsd_committer freebsd_triage 2019-09-05 08:21:41 UTC
imho we should proceed with this change, Jan, will you provide a patch? if not I will do it in the next couple of days.
Comment 5 Jan Beich freebsd_committer freebsd_triage 2022-08-26 11:13:20 UTC
(In reply to Baptiste Daroussin from comment #4)
> Resolution: --- → Overcome By Events

Care to elaborate? I don't see any recent commits to Templates/config.guess, so FreeBSD Ports is still a special snowflake that requires s/x86_64/amd64/ in autotools-based projects. DragonFly and NetBSD don't require such patching on x86_64.
Comment 6 Baptiste Daroussin freebsd_committer freebsd_triage 2022-08-26 12:47:05 UTC
Sorry I messed up with another PR, anyway this will be covered by 266049