Bug 208507 - [new port] mail/rubygem-premailer: Improve the rendering of HTML emails
Summary: [new port] mail/rubygem-premailer: Improve the rendering of HTML emails
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks: 208508 208511
  Show dependency tree / graph
 
Reported: 2016-04-04 12:53 UTC by Torsten Zühlsdorff
Modified: 2016-04-07 18:07 UTC (History)
1 user (show)

See Also:

Attachments
shar with new port mail/rubygem-premailer (1.65 KB, text/plain)
2016-04-04 12:53 UTC, Torsten Zühlsdorff 		ports: maintainer-approval+
Details
shar with new port mail/rubygem-premailer (1.63 KB, patch)
2016-04-04 16:06 UTC, Torsten Zühlsdorff 		ports: maintainer-approval+
Details | Diff
shar with new port mail/rubygem-premailer v2 (13.34 KB, patch)
2016-04-07 07:56 UTC, Torsten Zühlsdorff 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Zühlsdorff 2016-04-04 12:53:01 UTC 
Created attachment 168959 [details]
shar with new port mail/rubygem-premailer

Hello,

attached a shar with the new port rubygem-premailer. This port improves the rendering of HTML emails and is a prerequisite for the update of www/gitlab.

Buildtests are done for 9.3, 10.0, 10.1, 10.2 and 10.3 amd64 and i386. Also a runtime test with www/gitlab was done. All is fine :)

Greetings,
Torsten
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2016-04-04 14:49:01 UTC 
Please remove ${PORTSDIR}/ from DEPENDS lines.
Comment 2 Torsten Zühlsdorff 2016-04-04 16:06:05 UTC 
Created attachment 168972 [details]
shar with new port mail/rubygem-premailer

Removed like requested! :)
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2016-04-06 18:19:48 UTC 
(In reply to Torsten Zühlsdorff from comment #2)
Somehow, the plist is not complete:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: bin/premailer
Comment 4 Torsten Zühlsdorff 2016-04-07 07:56:42 UTC 
Created attachment 169068 [details]
shar with new port mail/rubygem-premailer v2
Comment 5 Torsten Zühlsdorff 2016-04-07 08:03:05 UTC 
(In reply to Kurt Jaeger from comment #3)

> Somehow, the plist is not complete:

> ===> Checking for items in STAGEDIR missing from pkg-plist
> Error: Orphaned: bin/premailer

Mh, i'm curious why the testbuild worked. Because now it clearly did not work. I think i mixed it up with rubygem-premailer-rails. -.-

I've fixed the error, updated the shar and tested both gems.
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2016-04-07 18:03:00 UTC 
testbuilds are fine
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-04-07 18:04:54 UTC 
A commit references this bug:

Author: pi
Date: Thu Apr  7 18:04:19 UTC 2016
New revision: 412678
URL: https://svnweb.freebsd.org/changeset/ports/412678

Log:
  New port: mail/rubygem-premailer

  Improve the rendering of HTML emails by making CSS inline,
  converting links and warning about unsupported code.

  WWW: http://premailer.dialect.ca/

  PR:		208507
  Submitted by:	Torsten Zuehlsdorff <ports@toco-domains.de>

Changes:
  head/mail/Makefile
  head/mail/rubygem-premailer/
  head/mail/rubygem-premailer/Makefile
  head/mail/rubygem-premailer/distinfo
  head/mail/rubygem-premailer/pkg-descr
  head/mail/rubygem-premailer/pkg-plist
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2016-04-07 18:07:51 UTC 
Committed, thanks!