Bug 208582 - devel/google-perftools: Update to 2.5
Summary: devel/google-perftools: Update to 2.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-06 15:57 UTC by Yuri Victorovich
Modified: 2016-04-09 12:54 UTC (History)
1 user (show)

See Also:

Attachments
patch (8.32 KB, patch)
2016-04-06 15:57 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2016-04-06 15:57:35 UTC 
Created attachment 169041 [details]
patch

Passes poudriere.
Comment 1 Vanilla I. Shu freebsd_committer freebsd_triage 2016-04-07 02:45:17 UTC 
did not pass poudriere testing.


====> Compressing man pages (compress-man)
===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%DOCSDIR%%/AUTHORS
Error: Missing: %%DOCSDIR%%/ChangeLog
Error: Missing: %%DOCSDIR%%/INSTALL
Error: Missing: %%DOCSDIR%%/NEWS
Error: Missing: %%DOCSDIR%%/README
Error: Missing: %%DOCSDIR%%/README_windows.txt
Error: Missing: %%DOCSDIR%%/TODO
Error: Missing: %%DOCSDIR%%/cpuprofile-fileformat.html
Error: Missing: %%DOCSDIR%%/cpuprofile.html
Error: Missing: %%DOCSDIR%%/designstyle.css
Error: Missing: %%DOCSDIR%%/heap-example1.png
Error: Missing: %%DOCSDIR%%/heapprofile.html
Error: Missing: %%DOCSDIR%%/index.html
Error: Missing: %%DOCSDIR%%/overview.dot
Error: Missing: %%DOCSDIR%%/overview.gif
Error: Missing: %%DOCSDIR%%/pageheap.dot
Error: Missing: %%DOCSDIR%%/pageheap.gif
Error: Missing: %%DOCSDIR%%/pprof-test-big.gif
Error: Missing: %%DOCSDIR%%/pprof-test.gif
Error: Missing: %%DOCSDIR%%/pprof-vsnprintf-big.gif
Error: Missing: %%DOCSDIR%%/pprof-vsnprintf.gif
Error: Missing: %%DOCSDIR%%/pprof_remote_servers.html
Error: Missing: %%DOCSDIR%%/spanmap.dot
Error: Missing: %%DOCSDIR%%/spanmap.gif
Error: Missing: %%DOCSDIR%%/t-test1.times.txt
Error: Missing: %%DOCSDIR%%/tcmalloc-opspercpusec.vs.threads.1024.bytes.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspercpusec.vs.threads.128.bytes.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspercpusec.vs.threads.131072.bytes.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspercpusec.vs.threads.16384.bytes.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspercpusec.vs.threads.2048.bytes.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspercpusec.vs.threads.256.bytes.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspercpusec.vs.threads.32768.bytes.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspercpusec.vs.threads.4096.bytes.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspercpusec.vs.threads.512.bytes.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspercpusec.vs.threads.64.bytes.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspercpusec.vs.threads.65536.bytes.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspercpusec.vs.threads.8192.bytes.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspersec.vs.size.1.threads.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspersec.vs.size.12.threads.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspersec.vs.size.16.threads.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspersec.vs.size.2.threads.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspersec.vs.size.20.threads.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspersec.vs.size.3.threads.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspersec.vs.size.4.threads.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspersec.vs.size.5.threads.png
Error: Missing: %%DOCSDIR%%/tcmalloc-opspersec.vs.size.8.threads.png
Error: Missing: %%DOCSDIR%%/tcmalloc.html
Error: Missing: %%DOCSDIR%%/threadheap.dot
Error: Missing: %%DOCSDIR%%/threadheap.gif
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/google-perftools
====>> Error: check-plist failures detected
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2016-04-07 16:34:35 UTC 
I am puzzled by this because it passes poudriere for me on 10.
'make check-plist' returns no error with and without the DOCS option.

> # make check-plist
> ====> Checking for pkg-plist issues (check-plist)
> ===> Parsing plist
> ===> Checking for items in STAGEDIR missing from pkg-plist
> ===> Checking for items in pkg-plist which are not in STAGEDIR
> ===> No pkg-plist issues found (check-plist)

Any chance that the patch wasn't applied properly?
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-04-09 12:53:48 UTC 
A commit references this bug:

Author: sunpoet
Date: Sat Apr  9 12:53:18 UTC 2016
New revision: 412841
URL: https://svnweb.freebsd.org/changeset/ports/412841

Log:
  - Update to 2.5
  - While I'm here:
    - Use = for LIB_DEPENDS
    - Convert to new options target helper

  Changes:	https://github.com/gperftools/gperftools/releases
  PR:		208582
  Submitted by:	Yuri Victorovich <yuri@rawbw.com> (maintainer)

Changes:
  head/devel/google-perftools/Makefile
  head/devel/google-perftools/distinfo
  head/devel/google-perftools/files/patch-Makefile.in
  head/devel/google-perftools/files/patch-pprof
  head/devel/google-perftools/files/patch-src_pprof
  head/devel/google-perftools/files/patch-static_vars.cc
  head/devel/google-perftools/pkg-plist
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2016-04-09 12:54:19 UTC 
Committed. Thanks!