Bug 208625 - PATCH: mountcritremote: mount -d output format change regression
Summary: PATCH: mountcritremote: mount -d output format change regression
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: 10.3-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-04-08 00:54 UTC by corsmith
Modified: 2016-06-06 00:07 UTC (History)
0 users

See Also:


Attachments
mountcritremote patch (697 bytes, patch)
2016-04-08 00:54 UTC, corsmith
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description corsmith 2016-04-08 00:54:31 UTC
Created attachment 169096 [details]
mountcritremote patch

At some point the output format of mount -d changed from:

mount_tmpfs ...

to:

mount -t tmpfs

This had a side effect of causing mountcritremote to no longer notice when there were remote file system types that needed mounting.  The current check looks like:

case "`mount -d -a -t ${fstype}`" in
*mount_${fstype}*)
	echo -n "Mounting ${fsdecr} file systems:"

There is no _ in the current output so this will never match.

The attached patch simply checks if there is any output re-using the existing idiom earlier in the script to maintain consistency.

The new check looks like:

case "`mount -d -a -t ${fstype}`" in
'')
	;;
*)
	echo -n "Mounting ${fsdecr} file systems:"