Bug 208630 - [bsdinstall] zfsboot: Do not add swap to fstab when swapsize is 0
Summary: [bsdinstall] zfsboot: Do not add swap to fstab when swapsize is 0
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-sysinstall
URL:
Keywords: install, patch
Depends on:
Blocks:
 
Reported: 2016-04-08 09:09 UTC by Ganael LAPLANCHE
Modified: 2016-05-27 05:46 UTC (History)
2 users (show)

See Also:


Attachments
Patch against -CURRENT r297697 (998 bytes, patch)
2016-04-08 09:09 UTC, Ganael LAPLANCHE
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ganael LAPLANCHE 2016-04-08 09:09:02 UTC
Created attachment 169100 [details]
Patch against -CURRENT r297697

Hi,

Find attached a patch to bsdinstall's zfsboot script that prevents adding a swap line to fstab when swapsize is 0.

Best regards,

Ganael Laplanche.
Comment 1 Allan Jude freebsd_committer 2016-04-08 14:49:47 UTC
This looks like my fault.

I added this feature earlier, but didn't account for the case where a user would ask for 0 bytes of swap, but demand that that swap be encrypted.


Thanks for the patch.
Comment 2 commit-hook freebsd_committer 2016-04-08 15:05:55 UTC
A commit references this bug:

Author: allanjude
Date: Fri Apr  8 15:05:06 UTC 2016
New revision: 297712
URL: https://svnweb.freebsd.org/changeset/base/297712

Log:
  Do not add swap to fstab when swapsize is 0

  If a user requested encrypted swap, but 0 sized, it would still be added to fstab

  PR:		208630
  Submitted by:	Ganael LAPLANCHE <ganael.laplanche@corp.ovh.com>
  MFC after:	2 weeks
  Sponsored by:	ScaleEngine Inc.

Changes:
  head/usr.sbin/bsdinstall/scripts/zfsboot
Comment 3 Ganael LAPLANCHE 2016-05-27 05:46:38 UTC
Thanks Allan !