Bug 208642 - Add quirk for Corsair STRAFE Gaming Keyboard
Summary: Add quirk for Corsair STRAFE Gaming Keyboard
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: usb (show other bugs)
Version: 10.2-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: Hans Petter Selasky
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-04-08 21:08 UTC by Naram Qashat
Modified: 2016-04-29 11:39 UTC (History)
1 user (show)

See Also:


Attachments
USB Quirk for Corsair STRAFE Gaming Keyboard (1.19 KB, patch)
2016-04-08 21:08 UTC, Naram Qashat
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2016-04-08 21:08:58 UTC
Created attachment 169116 [details]
USB Quirk for Corsair STRAFE Gaming Keyboard

This adds a USB quirk to allow a Corsair STRAFE Gaming Keyboard to work with FreeBSD. It is based on the already existing quirks for the other 2 Corsair keyboards that have quirks already. The patch was against 10.3-RELEASE, but I imagine it could be ported to other versions of FreeBSD as well.

One minor, semi-annoying note with the keyboard under FreeBSD, though. Prior to booting FreeBSD, the keyboard works fine within the BIOS and the bootloader. Once booting, the keyboard shuts off, which is expected as the USB controllers need to be initialized by FreeBSD. Once FreeBSD initializes the USB controllers, the keyboard's Scroll Lock light begins to blink. I've read that this is because the keyboard has been placed into a "BIOS Mode" of some sort, but this model of keyboard doesn't contain a hardware switch that some other Corsair keyboards have to enable/disable BIOS Mode. It was happening even without the quirk in place. I do not know enough about the keyboard's BIOS Mode or FreeBSD's USB stack to know why this is happening.
Comment 1 Hans Petter Selasky freebsd_committer freebsd_triage 2016-04-09 10:04:12 UTC
Do you think that all of Corsair USB keyboards should have this quirk? Have you contacted the vendor about this?
Comment 2 Naram Qashat 2016-04-09 15:08:02 UTC
I have not tried to contact Corsair about this, as this is my first time owning a Corsair keyboard. I'll shoot them a message about it, though.
Comment 3 Naram Qashat 2016-04-10 23:17:38 UTC
Corsair says there is nothing they can do about the BIOS mode problem under FreeBSD.

As for the other question you asked about all Corsair USB keyboards needing the quirk, I cannot say for sure. My only suggestion would be to check if there are other FreeBSD users that are using Corsair USB keyboards.
Comment 4 Hans Petter Selasky freebsd_committer freebsd_triage 2016-04-11 07:15:01 UTC
Can Corsair tell if all of their keyboards are implemented the same?

--HPS
Comment 5 Naram Qashat 2016-04-12 18:41:39 UTC
I submitted another ticket to them, they say the STRAFE communicates the same as their previous models. I can only assume that means all Corsair keyboards communicate the same way. So I believe that means that all Corsair USB keyboards should have this quirk.
Comment 6 Hans Petter Selasky freebsd_committer freebsd_triage 2016-04-13 06:59:32 UTC
Thank you.

I'll update the patch and make a fix by the end of this week.
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-04-21 17:45:43 UTC
A commit references this bug:

Author: hselasky
Date: Thu Apr 21 17:45:37 UTC 2016
New revision: 298424
URL: https://svnweb.freebsd.org/changeset/base/298424

Log:
  Add new USB quirk.

  Submitted by:	Naram Qashat <cyberbotx@cyberbotx.com>
  PR:		208642
  MFC after:	1 week

Changes:
  head/sys/dev/usb/quirk/usb_quirk.c
  head/sys/dev/usb/usbdevs
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-04-29 11:37:57 UTC
A commit references this bug:

Author: hselasky
Date: Fri Apr 29 11:37:07 UTC 2016
New revision: 298781
URL: https://svnweb.freebsd.org/changeset/base/298781

Log:
  MFC r297696 and r298424:
  Add new USB quirks.

  Submitted by:	AJ <aleksanderlothe@live.com>
  PR:		208623
  Submitted by:	Naram Qashat <cyberbotx@cyberbotx.com>
  PR:		208642

Changes:
_U  stable/10/
  stable/10/sys/dev/usb/quirk/usb_quirk.c
  stable/10/sys/dev/usb/usbdevs
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-04-29 11:39:00 UTC
A commit references this bug:

Author: hselasky
Date: Fri Apr 29 11:38:46 UTC 2016
New revision: 298782
URL: https://svnweb.freebsd.org/changeset/base/298782

Log:
  MFC r297696 and r298424:
  Add new USB quirks.

  Submitted by:	AJ <aleksanderlothe@live.com>
  PR:		208623
  Submitted by:	Naram Qashat <cyberbotx@cyberbotx.com>
  PR:		208642

Changes:
_U  stable/9/sys/
_U  stable/9/sys/dev/
  stable/9/sys/dev/usb/quirk/usb_quirk.c
  stable/9/sys/dev/usb/usbdevs