Bug 208674 - [maintainer] Update Port: databases/sqlite3 to 3.12.1
Summary: [maintainer] Update Port: databases/sqlite3 to 3.12.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-10 13:51 UTC by Pavel Volkov
Modified: 2016-04-13 15:30 UTC (History)
1 user (show)

See Also:


Attachments
Update Port: databases/sqlite3 to 3.12.1 (1.13 KB, patch)
2016-04-10 13:51 UTC, Pavel Volkov
pavelivolkov: maintainer-approval+
Details | Diff
build log (17.54 KB, text/plain)
2016-04-10 13:52 UTC, Pavel Volkov
no flags Details
portlint log (21.36 KB, text/plain)
2016-04-10 13:53 UTC, Pavel Volkov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Volkov 2016-04-10 13:51:11 UTC
Created attachment 169148 [details]
Update Port: databases/sqlite3 to 3.12.1

Update port to version 3.12.1.
Comment 1 Pavel Volkov 2016-04-10 13:52:00 UTC
Created attachment 169149 [details]
build log
Comment 2 Pavel Volkov 2016-04-10 13:53:24 UTC
Created attachment 169150 [details]
portlint log
Comment 3 Kurt Jaeger freebsd_committer 2016-04-10 16:11:24 UTC
Changes:
  https://www.sqlite.org/changes.html

which says:

The SQLITE_DEFAULT_PAGE_SIZE is increased from 1024 to 4096. The SQLITE_DEFAULT_CACHE_SIZE is changed from 2000 to -2000 so the same amount of cache memory is used by default. See https://www.sqlite.org/pgszchng2016.html

Do you as the maintainer see this as a risk-free upgrade or is more scrutiny recommended ?
Comment 4 Pavel Volkov 2016-04-13 13:50:50 UTC
Hello.
I think it is safe to update.

SQLITE_DEFAULT_PAGE_SIZE will be increased only for newly created databases,
previously created database files will be used saved in them values.
As described in https://www.sqlite.org/fileformat2.html,
"The page size for a database file is determined by the 2-byte integer located at an offset of 16 bytes from the beginning of the database file."
For those who like to keep the old page size can advise use pragma https://www.sqlite.org/pragma.html#pragma_page_size

SQLITE_DEFAULT_CACHE_SIZE only changes the form of the recording of their value, but the size remains unchanged.
Previously, it was the number of memory pages, and now - the size in Kibibytes.
As described in https://www.sqlite.org/pragma.html#pragma_cache_size

As described in https://www.sqlite.org/pgszchng2016.html, item 2, it is: "Not a Compatibility Break".

Thank you.
Comment 5 Kurt Jaeger freebsd_committer 2016-04-13 14:32:07 UTC
Testbuilds are fine.
Comment 6 commit-hook freebsd_committer 2016-04-13 15:28:59 UTC
A commit references this bug:

Author: pi
Date: Wed Apr 13 15:28:26 UTC 2016
New revision: 413212
URL: https://svnweb.freebsd.org/changeset/ports/413212

Log:
  databases/sqlite3: 3.11.1 -> 3.12.1

  Changes:
    https://www.sqlite.org/changes.html

  PR:		208674
  Submitted by:	Pavel Volkov <pavelivolkov@gmail.com> (maintainer)

Changes:
  head/databases/sqlite3/Makefile
  head/databases/sqlite3/distinfo
Comment 7 Kurt Jaeger freebsd_committer 2016-04-13 15:30:04 UTC
Committed, thanks!