Bug 208680 - usr/src/sys/arm/allwinner/clk/aw_lcdclk.c:284: possible bad test ?
Summary: usr/src/sys/arm/allwinner/clk/aw_lcdclk.c:284: possible bad test ?
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: arm (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Jared McNeill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-10 18:31 UTC by David Binderman
Modified: 2016-04-26 12:38 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2016-04-10 18:31:01 UTC 
[usr/src/sys/arm/allwinner/clk/aw_lcdclk.c:284]: (style) Expression '(X & 0x800) == 0x1' is always false.

Source code is

       if ((val & CH1_SCLK1_SEL) == CH1_SCLK1_SEL_SCLK2_DIV2)
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-04-26 12:37:02 UTC 
A commit references this bug:

Author: jmcneill
Date: Tue Apr 26 12:36:12 UTC 2016
New revision: 298634
URL: https://svnweb.freebsd.org/changeset/base/298634

Log:
  Fix calculation of LCD CH1 SCLK1 output frequency when SCLK2 /2 is used
  as source.

  PR:		208680
  Reported by:	David Binderman <dcb314@hotmail.com>

Changes:
  head/sys/arm/allwinner/clk/aw_lcdclk.c
Comment 2 Jared McNeill freebsd_committer freebsd_triage 2016-04-26 12:38:14 UTC 
Fixed in base r298634 - thanks for the report!