Bug 208727 - ftp/lftp: Fix build with libc++ 3.8.0
Summary: ftp/lftp: Fix build with libc++ 3.8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ganael LAPLANCHE
URL:
Keywords:
Depends on:
Blocks: 208158
  Show dependency tree / graph
 
Reported: 2016-04-11 20:05 UTC by Dimitry Andric
Modified: 2016-04-11 21:22 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (martymac)

Attachments
Disable custom max_align_t definition for ftp/lftp (436 bytes, patch)
2016-04-11 20:05 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2016-04-11 20:05:27 UTC 
Created attachment 169222 [details]
Disable custom max_align_t definition for ftp/lftp

During the exp-run in bug 208158, it was found that ftp/lftp gives errors with libc++ 3.8.0 [1]:

In file included from PollVec.cc:20:
In file included from ../lib/config.h:1913:
In file included from ../lib/gettext.h:25:
In file included from /usr/local/include/libintl.h:21:
In file included from ../lib/locale.h:46:
../lib/stddef.h:104:3: error: typedef redefinition with different types ('union max_align_t' vs 'long double')
} max_align_t;
  ^
/usr/include/c++/v1/stddef.h:57:21: note: previous definition is here
typedef long double max_align_t;
                    ^

This is because lftp contains a gl/stddef.h, which tries to fix possible omissions in the standard stddef.h header.  Unfortunately, this clashes in C++ mode with the stddef.h from libc++.  Fix this similarly to bug 208175, by telling the configure script that the system already has max_align_t, through setting ac_cv_type_max_align_t=yes.

[1] http://package18.nyi.freebsd.org/data/headamd64PR208158-default/2016-03-22_18h30m05s/logs/errors/lftp-4.6.5.log
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-04-11 21:21:19 UTC 
A commit references this bug:

Author: martymac
Date: Mon Apr 11 21:20:41 UTC 2016
New revision: 413087
URL: https://svnweb.freebsd.org/changeset/ports/413087

Log:
  Fix build with libc++ 3.8.0

  PR:		208727
  Submitted by:	dim

Changes:
  head/ftp/lftp/Makefile
Comment 2 Ganael LAPLANCHE freebsd_committer freebsd_triage 2016-04-11 21:22:25 UTC 
Committed, thanks!