This problem occurs when option CUPS is enabled in make config! 

As a workaround, disable CUPS. But this is nonesense, since the printer support is essential.

Comment 2 Mikael Urankar 2016-04-13 18:15:54 UTC

Created attachment 169295 [details]
clearenv fix

Same here, the attached patch fixes the build

(In reply to ohartman from comment #1)

I am having the same problem whether "CUP" is set or not.

You are correct, I was mistaken and there was a confusion. This port suffers now for aeons from an unclean build: it fails on some boxes, when net/samba{43|42} is already installed and about to be updated (pkg deleting the port helps) or it fails in case of an installation of the outdated and still used port samba36-smbclient, which has also to be deleted. This happens in our case mostly on boxes with not-only the system compiler installed, but also clang/llvm/gcc from ports. So I guess there is a bug in the resolution of the paths when searching for libraries expected to be taken from the port build but the linker finds first those from the regular installed port ...

The patch provided here helped in my case! I look forward to see it committed soon.

After some struggle with update on one box I decided to deinstall the whole port and perform a "portmaster -f net/samba43". The result (patch applied as given here) is another strange error. This is boring:

[...]

../source3/lib/netapi/tests/netshare.c:57:29: warning: comparison of constant 234 with expression of type 'NET_API_STATUS' is always false [-Wtautological-constant-out-of-range-compare]
                if (status == 0 || status == ERROR_MORE_DATA) {
                                   ~~~~~~ ^  ~~~~~~~~~~~~~~~
../source3/lib/netapi/tests/netshare.c:106:18: warning: comparison of constant 234 with expression of type 'NET_API_STATUS' is always false [-Wtautological-constant-out-of-range-compare]
        } while (status == ERROR_MORE_DATA);
                 ~~~~~~ ^  ~~~~~~~~~~~~~~~
../source3/lib/netapi/tests/netshare.c:127:24: error: variable has incomplete type 'struct SHARE_INFO_502'
        struct SHARE_INFO_502 i502;
                              ^
../source3/lib/netapi/tests/netshare.c:127:9: note: forward declaration of 'struct SHARE_INFO_502'
        struct SHARE_INFO_502 i502;
               ^
../source3/lib/netapi/tests/netshare.c:192:24: warning: comparison[3272/3873] Compiling source3/lib/netapi/examples/join/getjoinableous.c


[...]

(In reply to mikael.urankar from comment #2)
Thank you Mikael.  Confirmed fix on 10.3-Stable i386 & amd64.

Oliver, yes the number of warning messages is disconcerting, particularly the tautological errors on an i386 platform!  I often wonder if the upstream folks read their build logs. Fortunately Timur does a great job keeping Samba functioning on FreeBSD :)

Comment 7 commit-hook 2016-04-21 02:20:30 UTC

A commit references this bug:

Author: timur
Date: Thu Apr 21 02:19:31 UTC 2016
New revision: 413713
URL: https://svnweb.freebsd.org/changeset/ports/413713

Log:
  Fixed problem with the undeclared clearenv() that broke the build.
  Applied additional patches to fix problem with talloc 2.1.6 and failed provisioning, thanks to Andrey Kramarenko for pointing me to the patches and support.

  PR:		208767
  		208767

Changes:
  head/net/samba43/Makefile
  head/net/samba43/files/extra-patch-talloc
  head/net/samba43/files/patch-source3_client_smbspool_krb5_wrapper.c
  head/net/samba43/pkg-plist

(In reply to commit-hook from comment #7)
I am still experiencing a problem trying to get samba 43 installed. It now terminates with the following message.

/usr/local/lib/libtevent-util.so: undefined reference to `map_nt_error_from_unix_common@SAMBA_4.3.3'
/usr/local/lib/libtevent-util.so: undefined reference to `ntstatus_to_werror@SAMBA_4.3.3'
[3376/3871] Linking default/source3/libsmbd-conn-samba4.so
cc: error: linker command failed with exit code 1 (use -v to see invocation)
runner cc default/source3/smbd/conn_87.o -o /usr/ports/net/samba43/work/samba-4.3.8/bin/default/source3/libsmbd-conn-samba4.so -L/usr/local/lib -fstack-protector -Wl,-z,relro,-z,now -lpthread -Wl,-no-undefined -Wl,--export-dynamic -Wl,--as-needed -shared -Wl,--version-script=/usr/ports/net/samba43/work/samba-4.3.8/bin/default/source3/smbd_conn.vscript -Wl,-rpath,/usr/ports/net/samba43/work/samba-4.3.8/bin/shared -Wl,-rpath,/usr/ports/net/samba43/work/samba-4.3.8/bin/shared/private -Ldefault/lib/replace -Ldefault/lib/util -Ldefault/source3 -Wl,-Bdynamic -lsamba3-util-samba4 -lsamba-util -lreplace-samba4 -ltime-basic-samba4 -lutil-setid-samba4 -lsamba-debug-samba4 -lgenrand-samba4 -lsocket-blocking-samba4 -lcrypt -lrt -lmd -liconv -ltevent -ltalloc -lexecinfo
Waf: Leaving directory `/usr/ports/net/samba43/work/samba-4.3.8/bin'
Build failed:  -> task failed (err #1): 
	{task: cc_link async_sock_1.o,async_connect_send_test_2.o -> async_connect_send_test}
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/net/samba43
*** Error code 1

Stop.
make: stopped in /usr/ports/net/samba43

The entire build log is located here: http://www.seibercom.net/net_samba43.log

Comment 9 Timur I. Bakeyev 2016-04-23 12:08:17 UTC

(In reply to Gerard Seibert from comment #8)

Hi, Gerard!

It's unrelated issue, caused by injection of the old samba libraries into the build path. Hm.. Saying that that tipped me how to enforce it in the future...

But anyhow, the problem comes from the start of the configure script:

Checking uname sysname type              : runner cc -pipe -fno-omit-frame-pointer -DLIBICONV_PLUG -fno-color-diagnostics -g -fstack-protector -DLDAP_DEPRECATED -fno-strict-aliasing -MD -I/usr/local/include -DLIBICONV_PLUG -Idefault -I.. -Idefault -I.. -D_SAMBA_BUILD_=4 -DHAVE_CONFIG_H=1 ../test.c -c -o default/test_1.o
runner cc default/test_1.o -o /usr/ports/net/samba43/work/samba-4.3.8/bin/.conf_check_0/testbuild/default/testprog -L/usr/local/lib -fstack-protector
Even at that stage we get evil '-L/usr/local/lib' injected into the linking flags.

So, can you provide me with the:

/etc/make.conf
'cc -v' output
list of installed packages
samba43/work/samba-4.3.8/bin/config.log
port config options


For me, for example, configure gives:

Checking uname sysname type              : runner cc -pipe -fno-omit-frame-pointer -DLIBICONV_PLUG -fno-color-diagnostics -g -fstack-protector -DLDAP_DEPRECATED -fno-strict-aliasing -MD -DLIBICONV_PLUG -Idefault -I.. -Idefault -I.. -D_SAMBA_BUILD_=4 -DHA
VE_CONFIG_H=1 ../test.c -c -o default/test_1.o
runner cc default/test_1.o -o /usr/ports/net/samba43/work/samba-4.3.8/bin/.conf_check_0/testbuild/default/testprog -fstack-protector


Note the absence of 'evil' -L/usr/local/lib