Bug 208773 - devel/llvm37: build failure unless EXTRAS
Summary: devel/llvm37: build failure unless EXTRAS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-13 12:34 UTC by Helge Oldach
Modified: 2016-04-13 23:44 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (brooks)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Oldach 2016-04-13 12:34:04 UTC
When the EXTRAS option is /not/ set, building fails as follows:

/bin/rm -f /usr/obj/usr/ports/devel/llvm37/work/llvm-3.7.1.src/tools/clang/tools/scan-view/Reporter.py
/bin/rm -f /usr/obj/usr/ports/devel/llvm37/work/llvm-3.7.1.src/tools/clang/tools/scan-view/ScanView.py
/bin/rm -f /usr/obj/usr/ports/devel/llvm37/work/llvm-3.7.1.src/tools/clang/tools/scan-view/scan-view
/bin/rm -f /usr/obj/usr/ports/devel/llvm37/work/llvm-3.7.1.src/tools/clang/tools/scan-view/startfile.py
===>  Patching for llvm37-3.7.1_2
sed: tools/clang/tools/extra/clang-tidy/tool/clang-tidy-diff.py: No such file or directory
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/devel/llvm37
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/llvm37
#

The reason is that the shebang fix introduced in r413159 touches a file that is not present without EXTRAS.

Bug fix is trivial: include SHEBANG_FILES within a
.if ${PORT_OPTIONS:MEXTRAS}
.endif
clause.
Comment 1 commit-hook freebsd_committer 2016-04-13 21:55:38 UTC
A commit references this bug:

Author: brooks
Date: Wed Apr 13 21:54:46 UTC 2016
New revision: 413231
URL: https://svnweb.freebsd.org/changeset/ports/413231

Log:
  Fix build with EXTRAS disabled.

  PR:		208773
  Submitted by:	Helge Oldach <freebsd@oldach.net>

Changes:
  head/devel/llvm37/Makefile
Comment 2 Brooks Davis freebsd_committer 2016-04-13 23:44:43 UTC
Thanks for the report.