Bug 208785 - [release notes] change information about bell_enable sysctl key
Summary: [release notes] change information about bell_enable sysctl key
Status: Closed Overcome By Events
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: FreeBSD Release Engineering
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-04-13 18:38 UTC by David Marec
Modified: 2019-01-21 18:46 UTC (History)
8 users (show)

See Also:


Attachments
new tunable enable_bell (349 bytes, patch)
2016-04-13 20:04 UTC, David Marec
david: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Marec 2016-04-13 18:38:16 UTC
There is a misprint  in both 10.3 release notes and commit message,
about the new vt sysctl key.

https://www.freebsd.org/releases/10.3R/relnotes.html#kernel
https://svnweb.freebsd.org/base?view=revision&revision=287782


the key to enable/disable bell in vt is not
    bell_enable 
but 
enable_bell
 into kern.vt 's OIDs.


Moreover, there is still nothing about this in vt(4) man page.
Comment 1 David Marec 2016-04-13 20:04:37 UTC
Created attachment 169298 [details]
new tunable enable_bell

To update the man page, the few lines:

+.It Va kern.vt.enable_bell
+Enable terminal bell.

may be enough.
Comment 2 Ben Woods freebsd_committer 2016-04-15 08:38:52 UTC
Copying in the two people involved in the original commit:
Tiwei Bie <btw@mail.ustc.edu.cn>
Aleksandr Rybalko <ray@freebsd.org>
Comment 3 Tiwei Bie 2016-04-15 09:14:26 UTC
(In reply to david.marec from comment #0)

Yes, the key is enable_bell.
Comment 4 Tiwei Bie 2016-04-15 09:19:51 UTC
(In reply to david.marec from comment #1)

I don't think it's a good idea to put these lines to the 'KEYBOARD SYSCTL TUNABLES' section. Maybe a new section should be added?
Comment 5 commit-hook freebsd_committer 2016-04-18 02:37:26 UTC
A commit references this bug:

Author: wblock
Date: Mon Apr 18 02:36:49 UTC 2016
New revision: 298176
URL: https://svnweb.freebsd.org/changeset/base/298176

Log:
  Add the kern.vt.enable_bell sysctl, which was not documented previously.
  Minor additional punctuation and wording changes.

  PR:		208785
  Submitted by:	david.marec@davenulle.org
  MFC after:	1 week

Changes:
  head/share/man/man4/vt.4
Comment 6 Warren Block freebsd_committer 2016-04-18 02:39:31 UTC
I have updated the man page.
Comment 7 Benedict Reuschling freebsd_committer 2016-05-08 12:45:55 UTC
Is the MFC done, so we can close this PR?
Comment 8 Warren Block freebsd_committer 2016-05-08 15:17:17 UTC
The MFC is done, but the release notes are re@ territory and I did not change them.
Comment 9 Mark Linimon freebsd_committer freebsd_triage 2018-08-05 06:18:26 UTC
Assign to maintainer of release notes.  This may be OBE by now, though.
Comment 10 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-01-21 18:46:59 UTC
Closing as OBE, there is no point in updating release notes now.