Created attachment 169491 [details] patch file for altering _librsyncmodule.c, taken with credit from fedora sysutils/rdiff-backup which is very useful depends on the insecure net/librsync. The logical step is to move from old net/librsync to the new net/librsync1, but this introduces a compile-time error breaking the port. The same compiler error exists for both ports sysutils/rdiff-backup and sysutils/rdiff-backup-devel; both errors are corrected by the same patch. A possible solution is to add the patchfile (attached), and alter the Makefile for both rdiff-backup ports (sysutils/rdiff-backup*/Makefile) changing the LIB_DEPENDS from net/librsync to net/librsync1 (i.e., add the number "1" to the end of that line in the Makefile). Potential problems: a) net/librsync and net/librsync1 cannot co-exist on a system b) the old, vulnerable net/librsync is required by (according to FreshPorts): devel/codeblocks sysutils/duplicity in addition to the two rdiff-backup ports. I would think that the maintainers of those two ports might consider moving away from the insecure-and-unmaintained net/librsync to the newer net/librsync1. Thanks for reading, --MCV.
Created attachment 169539 [details] complete patch This patch contains the submitter's patch and the needed modifications of Makefile. Poudriere log: http://freebsd.uzsolt.hu/logs/rdiff-backup/rdiff-backup-1.2.8_2%2C1.log Portlint log: http://freebsd.uzsolt.hu/logs/rdiff-backup/rdiff-backup-1.2.8_2%2C1.portlint.log @mvoorhis: thanks for your notice!
A commit references this bug: Author: arved Date: Thu May 12 11:24:54 UTC 2016 New revision: 415061 URL: https://svnweb.freebsd.org/changeset/ports/415061 Log: Switch dependency from old net/librsync to net/librsync1 PR: 208934 Submitted by: mvoorhis@cs.wpi.edu Approved by: maintainer Changes: head/sysutils/rdiff-backup/Makefile head/sysutils/rdiff-backup/files/patch-__librsyncmodule.c
committed, thanks