Created attachment 169494 [details] Preserve spaces and tabs between quotes in /usr/sbin/config I should be able to set values with spaces in my kernel static environment (option 'env mykernel-static-env.env' in my kernel config, as long as they are between quotes. For instance, I want to be able to set: loader_conf_files="/boot/loader.conf /boot/loader.conf.local" Right now, this gets transformed into: loader_conf_files="/boot/loader.conf/boot/loader.conf.local" Attached patch fixes the issue and preserves spaces and tabs.
Created attachment 169500 [details] Preserve spaces and tabs between quotes in /usr/sbin/config Correct patch attached
Hi, Sorry for the radio silence on this. I committed a new version of the env line sanitizer (written by ian@) in r335642 which also fixed this, and later revisions to config(8) fixed this same kind of bug in hints. I'll be MFC'ing the rewrite and all of my other env work (deduplication, fixing the order of precedence) likely this weekend. Thanks, Kyle Evans
Hi Kyle, what were the revision(s) for the merge(s), and did this go/need to go to stable/12?
(In reply to Kubilay Kocak from comment #3) Hi, Sorry, I should have been informative. =) The commit for this that rewrote the offending parser predated stable/12, r335642; it was merged to stable/11 in r335863, so all supported branches have the fix. Thanks, Kyle Evans
Thanks! For bonus linking points: base r335642 (current: 12.0) base r335863 (mfc: stable/11)