Bug 209055 - make delete-old and WITHOUT_LEGACY_CONSOLE=true doesn't remove superfluous files
Summary: make delete-old and WITHOUT_LEGACY_CONSOLE=true doesn't remove superfluous files
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 10.3-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-04-25 20:00 UTC by Philippe Michel
Modified: 2018-08-14 23:59 UTC (History)
1 user (show)

See Also:

Attachments
Possible patch (756 bytes, patch)
2016-04-25 20:00 UTC, Philippe Michel 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Michel 2016-04-25 20:00:46 UTC 
Created attachment 169696 [details]
Possible patch

If WITHOUT_LEGACY_CONSOLE is set to true, "make delete-old" doesn't remove the files that may remain from when this option was not used.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2018-08-12 14:40:10 UTC 
Is this PR still relevant?
Comment 2 Philippe Michel 2018-08-14 14:08:20 UTC 
It seems it has been fixed at some point. At least, on the 11-STABLE version I now use, a change similar to the patch I had attached to the PR has been applied to tools/build/mk/OptionalObsoleteFiles.inc.

That said, I no longer use WITHOUT_LEGACY_CONSOLE since it breaks kernel builds using the KBDMUX_DFLT_KEYMAP option (see sys/conf/files and the "kbdmuxmap.h ... compile-with kbdcontrol ..." line).

That is, whether you use legacy console or vt, to support other keyboards than standard qwerty early enough for them to be available in single user mode, you need kbdcontrol and the latter depends on LEGACY_CONSOLE.

I suppose this last point deserves a separate PR (maybe there is already one) but when I stumbled on the issue I was just re-enabled the option.