Bug 209059 - databases/opentsdb: rc script should allow JVMARGS to be set in rc.conf
Summary: databases/opentsdb: rc script should allow JVMARGS to be set in rc.conf
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kevin Bowling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-26 00:49 UTC by Kevin Bowling
Modified: 2019-02-28 20:18 UTC (History)
3 users (show)

See Also:
xmj: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Bowling freebsd_committer freebsd_triage 2016-04-26 00:49:40 UTC 
The opentsdb rc script calls /usr/local/bin/tsdb which has a variable, JVMARGS, that can be used to set additional JVM arguments.  We should be able to set things like max heap size and GC tuning in rc.conf opentsdb flags.
Comment 1 Johannes Jost Meixner freebsd_committer freebsd_triage 2016-04-26 01:12:00 UTC 
Something like this should work in the rc.d script:

: ${opentsdb_jvmargs:=$reasonable_default_here}

combined with an export of JVMARGS=$opentsdb_jvmargs before the run_rc_command.
Comment 2 Johannes Jost Meixner freebsd_committer freebsd_triage 2017-06-05 08:35:43 UTC 
Re-assign to maintainer
Comment 3 Walter Schwarzenfeld 2018-02-07 13:49:52 UTC 
Any news here?
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-02-28 20:13:45 UTC 
A commit references this bug:

Author: kbowling
Date: Thu Feb 28 20:13:18 UTC 2019
New revision: 494186
URL: https://svnweb.freebsd.org/changeset/ports/494186

Log:
  databases/opentsdb: rc script should allow JVMARGS to be set

  PR:		209059
  Approved by:	krion (mentor)
  Sponsored by:	BBOX.io
  Differential Revision:	https://reviews.freebsd.org/D19362

Changes:
  head/databases/opentsdb/files/opentsdb.in