Created attachment 170015 [details] www_xombrero.diff
A commit references this bug: Author: rm Date: Thu May 5 21:44:54 UTC 2016 New revision: 414668 URL: https://svnweb.freebsd.org/changeset/ports/414668 Log: www/xombrero: unbreak; update to 1.6.4 This patch is cherry-picked from 4 different PRs and one upstream bug report [1] Changes are: - fix build and runtime (based on [1]). I also tried patches and solutions from PR's, but they didn't worked for some reason - update to 1.6.4 - convert to options helpers and add other simplifications to Makefile - sync installed files with Makefile, bundled into distribution - add upstream patch to fix some GTK3 warnings This was tested both at build and runtime with both GTK versions. Also HTML5 video playback was tested - there was a report that it doesn't work. [1] https://github.com/conformal/xombrero/issues/131 PR: 192779 203939 205646 209301 Submitted by: various persons Changes: head/www/xombrero/Makefile head/www/xombrero/distinfo head/www/xombrero/files/patch-freebsd__Makefile head/www/xombrero/files/patch-xombrero.css head/www/xombrero/pkg-descr head/www/xombrero/pkg-plist
Update to 1.6.4 was just committed. Most of the changes from your patch were merged. Thanks.
Oh, Mathieu, sorry, my bad((
Well, desktop entry file and layout of icons in r414668 (and previous versions) does not seem to follow freedesktop.org standard.
I see. However I'm sure this should be submitted upstream instead. Just do a pull request at https://github.com/conformal/xombrero. Upstream maintainer is quite responsive.
By the way, icon names are hardcoded in xombrero.c, so it may require to change that too.
Created attachment 170043 [details] www_xombrero.diff Hmm, it seems xombrero.c assumes PNG images are installed in $DATADIR. Icons under $PREFIX/share/icons have to be made as symlinks from PNG images in $DATADIR. Workaround for pararell building is also implemented.
Please send this changes upstream. There is no point to maintain local patches when this could be just upstreamed and work out of the box. Users of other platforms will also benefit from this change. Thanks. EXAMPLES option and conditional installation of examples will be committed soon. I missed that because no information in PR about what changes were introduced and why. PS. "GTK;WebBrower" looks like a typo to me.
Although Category field in xombrero.desktop might possibly be worth informing, other things do not seem adequate to involve upstream. At least, location of PNG images in existing port is an obvious bug. The original $WRKSRC/freebsd/Makefile also intend to install images into $DATADIR.
Created attachment 170577 [details] www_xombrero.diff Fix typo
Reopen
Reassign to current maintainer.
What is the reason for still open?